[cleanup]: remove deprecated liveness driver and related metrics artifacts - #6003
[cleanup]: remove deprecated liveness driver and related metrics artifacts#6003Coderxrohan wants to merge 3 commits into
Conversation
e4f0c49 to
aa19fd2
Compare
Madhu-1
left a comment
Madhu-1
left a comment
There was a problem hiding this comment.
@Coderxrohan Thanks for the work, did you get a chance to verify that profing endpoint works if we remove it? what about the code in the liveness.go?
|
This is kind of a breaking change, we need to add it to Pending release notes. cc @Rakshith-R @nixpanic |
Signed-off-by: Rohan Satkar <coderxrohan@gmail.com>
Signed-off-by: Rohan Satkar <coderxrohan@gmail.com>
1234a6d to
f44ce82
Compare
@Madhu-1, Agree that this is a breaking change, |
|
| | `--pidlimit` | _0_ | Configure the PID limit in cgroups. The container runtime can restrict the number of processes/tasks which can cause problems while provisioning (or deleting) a large number of volumes. A value of `-1` configures the limit to the maximum, `0` does not configure limits at all. | | ||
| | `--metricsport` | `8080` | TCP port for liveness metrics requests | | ||
| | `--metricspath` | `"/metrics"` | Path of prometheus endpoint where metrics will be available | | ||
| | `--polltime` | `"60s"` | Time interval in between each poll | |
There was a problem hiding this comment.
we can remove polltime & timeout from here?
There was a problem hiding this comment.
Sure, this will work. I have removed them. Thanks!
| | `--pluginpath` | "/var/lib/kubelet/plugins/" | The location of cephcsi plugin on host | | ||
| | `--pidlimit` | _0_ | Configure the PID limit in cgroups. The container runtime can restrict the number of processes/tasks which can cause problems while provisioning (or deleting) a large number of volumes. A value of `-1` configures the limit to the maximum, `0` does not configure limits at all. | | ||
| | `--metricsport` | `8080` | TCP port for liveness metrics requests | | ||
| | `--metricspath` | `/metrics` | Path of prometheus endpoint where metrics will be available | |
There was a problem hiding this comment.
Why metricspath is removed here?
There was a problem hiding this comment.
Thanks for pointing this out.
polltime and timeout were tied to the deprecated liveness driver, so they can be removed from docs as well,
I’ll update that.
metricspath was unintentionally dropped in cephfs; I’ll restore it for consistency with RBD.
Signed-off-by: Rohan Satkar <coderxrohan@gmail.com>
e646090 to
e2871c4
Compare
|
@iPraveenParihar |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
iPraveenParihar
left a comment
iPraveenParihar
left a comment
There was a problem hiding this comment.
@Coderxrohan, Can you address the CI failures?
| - "--metricspath=/metrics" | ||
| - "--polltime=60s" | ||
| - "--timeout=3s" | ||
| env: |
There was a problem hiding this comment.
Forgot to remove env, volumeMounts, imagePullPolicy fields.
| driver := nvmeofdriver.NewDriver() | ||
| driver.Run(&conf) | ||
| case util.LivenessType: | ||
| liveness.Run(&conf) |
There was a problem hiding this comment.
We can safely remove internal/liveness/ package?
| "metricspath", | ||
| "/metrics", | ||
| "path of prometheus endpoint where metrics will be available") | ||
| flag.DurationVar(&conf.PollTime, "polltime", time.Second*pollTime, "time interval in seconds between each poll") |
There was a problem hiding this comment.
Can we remove the unused pooltime and timeout flags which are used only in liveness component?
| | `--metricspath` | `"/metrics"` | Path of prometheus endpoint where metrics will be available | | ||
| | `--polltime` | `"60s"` | Time interval in between each poll | | ||
| | `--timeout` | `"3s"` | Probe timeout in seconds | | ||
|
|
There was a problem hiding this comment.
remove blank lines before and after
| fieldRef: | ||
| fieldPath: status.podIP | ||
| ports: | ||
| - containerPort: {{ .Values.provisioner.httpMetrics.containerPort }} |
There was a problem hiding this comment.
Can we remove httpMetrics.containerPort field and others which are no longer referenced from values.yaml from both rbd and cephfs?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required. |
3 participants
Issue:
Ceph-CSI includes a legacy liveness driver and related deployment artifacts (sidecar containers, Services, ServiceMonitors, and documentation) that are no longer needed. Kubernetes now provides native liveness and health probing, making the custom liveness driver redundant.
Fix:
Impact:
Level:
Medium-severity cleanup / technical debt reduction
Fixes: #5599