Skip to content

change base_estimator to estimator #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

jckkvs
Copy link

@jckkvs jckkvs commented Feb 22, 2023

@jckkvs
Copy link
Author

jckkvs commented Jul 19, 2024

Hello, @cerlymarco

In this pull request, I have made changes to ensure compatibility with the latest version of scikit-learn.

Changes Made

  1. Modified occurrences of base_estimator to estimator.
  2. Replaced max_features="auto" with max_features=1.0.

@jckkvs
Copy link
Author

jckkvs commented Nov 27, 2024

@cerlymarco
Hello, what do you think about this pull request?

@victoraalves
Copy link

victoraalves commented Jul 29, 2025

@cerlymarco Let me first acknowledge you for developing the linear-tree package. It is incredibly useful. Second, I'd like to report that I am facing the same issue that @jckkvs is reporting. Now in sklearn=1.7.0 the deprecation warning is extinct and the base_estimator is actually nonexistent, which unfortunately breaks linear-tree. Are there any plans to merge this into the main branch? I am more than happy to participate in reviewing this PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants