Implement nand - #952
Conversation
cb90bd4 to
9ab183c
Compare
|
I hopefully addressed all your feedback now! Thank you for the super quick response |
| neither(firstPredicate: Function, secondPredicate: Function): Function; | ||
|
|
||
| /** | ||
| * Returns `true` if both arguments are falsy, otherwise `false`. |
There was a problem hiding this comment.
This description is not sync with description in nand.js
| }); | ||
|
|
||
| it('should support currying', function() { | ||
| const trueNand = nand(true); |
There was a problem hiding this comment.
Pls import RA in following way import * as RA from '../src';
can we simplify into ?
it('should support currying', function() {
eq(RA.nand(true, true), false);
eq(RA.nand(true)(true), false);
});
char0n
left a comment
char0n
left a comment
There was a problem hiding this comment.
I've provided last to comments, after processing them we're good to merge. Sorry for a lot of comments, but we're trying to maintain consistency and quality of the codebase very hard ;]
|
No worries, I totally hear you about opensource projects. Keeping things consistent can be really hard. |
|
I've pushed up a change which hopefully addresses all your feedback. I hope rebasing the PRs is okay. |
char0n
left a comment
char0n
left a comment
There was a problem hiding this comment.
Very nice! Let's wait for tests and it's ready for a merge. Thank you again.
2 participants
Tries to solve #237
Note: While committing it, eslint-plugin-ramda had a bug, see ramda/eslint-plugin-ramda#26, so I disabled this specific eslint rule in the configuration. Maybe I'm missing something.