Skip to content

refactor: ♻️ extract url to environment variables #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: ♻️ extract url to environment variables #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c4d400
refactor: :recycle: extract url to environment variables
charlyautomatiza Mar 24, 2024
d0344be
refactor: :recycle: extract url to environment variables
charlyautomatiza Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const config: PlaywrightTestConfig = {
actionTimeout: 0,

/* Base URL to use in actions like `await page.goto('/')`. */
baseURL: 'https://charlyautomatiza.github.io/task-management-frontend',
baseURL: process.env.BASEURL_UI,

/* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
trace: 'on-first-retry',
Expand Down
2 changes: 1 addition & 1 deletion tests/api.data.class.example.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const userData = new UserData();
test.beforeEach(async ({ playwright }) => {
apiContext = await playwright.request.newContext({
// All requests we send go to this API endpoint.
baseURL: 'https://task-mgmt-charlyautomatiza.onrender.com',
baseURL: process.env.BASEURL_API,
extraHTTPHeaders: {
Accept: 'application/json',
},
Expand Down
2 changes: 1 addition & 1 deletion tests/api.data.example.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ let dataContext: APIRequestContext;
test.beforeEach(async ({ playwright }) => {
apiContext = await playwright.request.newContext({
// All requests we send go to this API endpoint.
baseURL: 'https://task-mgmt-charlyautomatiza.onrender.com',
baseURL: process.env.BASEURL_API,
extraHTTPHeaders: {
Accept: 'application/json',
},
Expand Down
2 changes: 1 addition & 1 deletion tests/api.ui.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ let apiContext: APIRequestContext;
test.beforeEach(async ({ playwright }) => {
apiContext = await playwright.request.newContext({
// All requests we send go to this API endpoint.
baseURL: 'https://task-mgmt-charlyautomatiza.onrender.com',
baseURL: process.env.BASEURL_UI,
extraHTTPHeaders: {
'Accept': 'application/json',
},
Expand Down