Configure framework to prefer data-test-id attributes for stable test selectors #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the suggestion from issue #[issue_number] to configure the Playwright test framework to prefer
data-test-id
attributes for element locators, following best practices for test automation.Changes
Configuration
Added
testIdAttribute: 'data-test-id'
toplaywright.config.ts
to enable the use of custom test ID attributes throughout the framework:Page Objects
Updated page object files to demonstrate best practices:
Before:
Recommended approach (documented in comments):
The page objects now include comprehensive comments showing:
getByTestId()
patternDocumentation
Added detailed sections in both
README.md
andLEEME.md
(Spanish) explaining:Benefits
data-test-id
attributesTesting
References
This change positions the framework to follow industry best practices while maintaining backward compatibility with existing tests.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
task-mgmt-charlyautomatiza.onrender.com
/usr/local/bin/node /home/REDACTED/work/starter-playwright/starter-playwright/node_modules/playwright/lib/common/process.js
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.