Fix min js two renames #11470
Merged
Fix min js two renames #11470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeLenaleee
previously approved these changes
Aug 28, 2023
etimberg
approved these changes
Aug 28, 2023
fulldecent
force-pushed
the
fix-min-js-two-renames
branch
from
5b825a9 to
699753f
Compare
|
@fulldecent I think the test failures might be real. It looks like it fails to import https://github.com/chartjs/Chart.js/blob/master/test/BasicChartWebWorker.js#L9 |
|
@etimberg requesting review please |
1 similar comment
|
@etimberg requesting review please |
etimberg
previously approved these changes
Jun 5, 2025
|
Sorry @fulldecent, was off on pat-leave for a while and didn't check github too closely. @LeeLenaleee ok if I merge this? |
|
The tests keep failing, also locally but so far I have not been able to figure out why this happens since the file does show up in the dist folder. I am not sure if we should merge it because I doubt that the failing test will disappear. |
|
@LeeLenaleee I have no idea what I'm doing. And nobody else is using Karma exactly how we do it. But somehow I got the build to pass. |
LeeLenaleee
approved these changes
Jun 10, 2025
etimberg
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternative that incorporates #11457