Skip to content

CHEF-20911 Fix to prevent invalid tags and characters for tags - updated #8927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

vinay033
Copy link
Collaborator

🔩 Description: What code changed, and why?

FIx for Chef Tag is accepting html text, url, all special characters

⛓️ Related Resources

https://progresssoftware.atlassian.net/browse/CHEF-20911

👍 Definition of Done

Added validation to prevent invalid characters and links.

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if

Screenshot 2025-07-02 at 8 47 15 PM Screenshot 2025-07-07 at 2 29 34 PM Screenshot 2025-07-07 at 2 28 31 PM Screenshot 2025-07-07 at 2 28 16 PM Screenshot 2025-07-07 at 2 27 51 PM applicable

Copy link

netlify bot commented Jul 15, 2025

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 1867d73
🔍 Latest deploy log https://app.netlify.com/projects/chef-automate/deploys/687dde42a36dec00088bc8f3

Signed-off-by: vinay sharma <[email protected]>
@vinay033 vinay033 force-pushed the Vinay/CHEF-20911-updated branch from 565251d to 1867d73 Compare July 21, 2025 06:29
@Dmaddu Dmaddu merged commit 454d48a into main Jul 21, 2025
10 of 13 checks passed
@Dmaddu Dmaddu deleted the Vinay/CHEF-20911-updated branch July 21, 2025 08:51
Aishwarya2001A pushed a commit that referenced this pull request Jul 21, 2025
Signed-off-by: vinay sharma <[email protected]>
Dmaddu pushed a commit that referenced this pull request Jul 22, 2025
* pg update

Signed-off-by: Aishwarya2001A <[email protected]>

* modification

Signed-off-by: Aishwarya2001A <[email protected]>

* license scout changes

Signed-off-by: Aishwarya2001A <[email protected]>

* changed core/sqitch/ version

Signed-off-by: Aishwarya2001A <[email protected]>

* sqitch pkg version change

Signed-off-by: Aishwarya2001A <[email protected]>

* sqitch pkg version change 2

Signed-off-by: Aishwarya2001A <[email protected]>

* updated regex (#8927)

Signed-off-by: vinay sharma <[email protected]>

* Bump version to 4.13.214 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

* Bump version to 4.13.215 by Chef Expeditor

Obvious fix; these changes are the result of automation not creative thinking.

* unpinned versions

Signed-off-by: Aishwarya2001A <[email protected]>

* a

Signed-off-by: Aishwarya2001A <[email protected]>

* a

Signed-off-by: Aishwarya2001A <[email protected]>

* a

Signed-off-by: Aishwarya2001A <[email protected]>

* a

Signed-off-by: Aishwarya2001A <[email protected]>

* a

Signed-off-by: Aishwarya2001A <[email protected]>

* sqitch LTS version pinned

Signed-off-by: Aishwarya2001A <[email protected]>

---------

Signed-off-by: Aishwarya2001A <[email protected]>
Signed-off-by: vinay sharma <[email protected]>
Co-authored-by: vinay sharma <[email protected]>
Co-authored-by: Chef Expeditor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants