(#962) Upgrade outdated on install

[Isopolito]

Hi, I made the changes for issue #962 and submitted them on this PR. I'm still working out how to get the unit test(s) created for it, but in the meantime i wanted to submit this since I have a few questions:

• Is deep copying a config and only changing PackageNames to what should be upgraded sufficient (line 1337), or do other things need to be modified in the new config before sending it off to upgrade_run?

• Is just removing a package name from config.PackageNames (line 1332) enough to make it disappear from the install process?

Thanks!

[ferventcoder]

@Isopolito it may be best to wait for #1132 to be implemented so you won't need to handle upgrades against packages.config files.

[ferventcoder]

Also, please read CONTRIBUTING - it does state we never want to see merge commits in pull requests.

[ferventcoder]

These changes regarding a packages.config file should wait for implementation of the upgrades with packages.config.

Please back out the merge commit and read over CONTRIBUTING for the correct way to do pull in updated changes.

[Isopolito]

Sorry about that, I'm new to this process. I read over contributing but still messed that up. I'll look over #1132 and wait for that to be implemented. Is there a preferred way to back out the merge commit?

[ferventcoder]

Is there a preferred way to back out the merge commit?

@Isopolito Yes, choco install gitextensions, ensure that gets configured appropriately and use it to help you back up to the older commit, then do a force push back to the branch on that (but be careful, force pushes should only be used in feature branches). We have an example of this in contributing.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

ahall seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}