Skip to content

replaced 3 deprecated generic calls to Create() #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replaced 3 deprecated generic calls to Create() #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 26 additions & 34 deletions src/CustomLayouts/Controls/CarouselLayout.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,14 @@ protected override void LayoutChildren (double x, double y, double width, double
_layingOutChildren = false;
}

public static readonly BindableProperty SelectedIndexProperty =
BindableProperty.Create<CarouselLayout, int> (
carousel => carousel.SelectedIndex,
0,
BindingMode.TwoWay,
propertyChanged: (bindable, oldValue, newValue) => {
((CarouselLayout)bindable).UpdateSelectedItem ();
}
);

public int SelectedIndex {
public static readonly BindableProperty SelectedIndexProperty =
BindableProperty.Create("SelectedIndex", typeof(int), typeof(CarouselLayout), 0, BindingMode.TwoWay,
propertyChanged: (bindable, oldValue, newValue) => {
((CarouselLayout)bindable).UpdateSelectedItem();
}
);

public int SelectedIndex {
get {
return (int)GetValue (SelectedIndexProperty);
}
Expand All @@ -88,19 +85,17 @@ void SelectedItemTimerElapsed (object sender, ElapsedEventArgs e) {
SelectedItem = SelectedIndex > -1 ? Children [SelectedIndex].BindingContext : null;
}

public static readonly BindableProperty ItemsSourceProperty =
BindableProperty.Create<CarouselLayout, IList> (
view => view.ItemsSource,
null,
propertyChanging: (bindableObject, oldValue, newValue) => {
((CarouselLayout)bindableObject).ItemsSourceChanging ();
},
propertyChanged: (bindableObject, oldValue, newValue) => {
((CarouselLayout)bindableObject).ItemsSourceChanged ();
}
);

public IList ItemsSource {
public static readonly BindableProperty ItemsSourceProperty =
BindableProperty.Create("ItemsSource", typeof(IList), typeof(CarouselLayout), null,
propertyChanging: (bindableObject, oldValue, newValue) => {
((CarouselLayout)bindableObject).ItemsSourceChanging();
},
propertyChanged: (bindableObject, oldValue, newValue) => {
((CarouselLayout)bindableObject).ItemsSourceChanged();
}
);

public IList ItemsSource {
get {
return (IList)GetValue (ItemsSourceProperty);
}
Expand Down Expand Up @@ -134,17 +129,14 @@ public DataTemplate ItemTemplate {
set;
}

public static readonly BindableProperty SelectedItemProperty =
BindableProperty.Create<CarouselLayout, object> (
view => view.SelectedItem,
null,
BindingMode.TwoWay,
propertyChanged: (bindable, oldValue, newValue) => {
((CarouselLayout)bindable).UpdateSelectedIndex ();
}
);
public static readonly BindableProperty SelectedItemProperty =
BindableProperty.Create("SelectedItem", typeof(object), typeof(CarouselLayout), null, BindingMode.TwoWay,
propertyChanged: (bindable, oldValue, newValue) => {
((CarouselLayout)bindable).UpdateSelectedIndex();
}
);

public object SelectedItem {
public object SelectedItem {
get {
return GetValue (SelectedItemProperty);
}
Expand Down