Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion source/NetCoreServer/WebSocket.cs
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,15 @@ public void PrepareReceiveFrame(byte[] buffer, long offset, long size)
}
}

payload = ((WsReceiveFrameBuffer[2] << 56) | (WsReceiveFrameBuffer[3] << 48) | (WsReceiveFrameBuffer[4] << 40) | (WsReceiveFrameBuffer[5] << 32) | (WsReceiveFrameBuffer[6] << 24) | (WsReceiveFrameBuffer[7] << 16) | (WsReceiveFrameBuffer[8] << 8) | (WsReceiveFrameBuffer[9] << 0));
payload = ((WsReceiveFrameBuffer[2] & 0xFFL) << 56) |
((WsReceiveFrameBuffer[3] & 0xFFL) << 48) |
((WsReceiveFrameBuffer[4] & 0xFFL) << 40) |
((WsReceiveFrameBuffer[5] & 0xFFL) << 32) |
((WsReceiveFrameBuffer[6] & 0xFFL) << 24) |
((WsReceiveFrameBuffer[7] & 0xFFL) << 16) |
((WsReceiveFrameBuffer[8] & 0xFFL) << 8) |
((WsReceiveFrameBuffer[9] & 0xFFL));

WsHeaderSize = 10 + (mask ? 4 : 0);
WsPayloadSize = payload;
}
Expand Down
43 changes: 43 additions & 0 deletions tests/WsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -352,5 +352,48 @@ public void WsServerRandomTest()
Assert.True(server.BytesReceived > 0);
Assert.True(!server.Errors);
}

[Fact(DisplayName = "WebSocket frame size validation test")]
public void WsFrameSizeValidationTest()
{
string address = "127.0.0.1";
int port = 8084;

var server = new EchoWsServer(IPAddress.Any, port);
Assert.True(server.Start());
while (!server.IsStarted)
Thread.Yield();

var client = new EchoWsClient(address, port);
Assert.True(client.ConnectAsync());
while (!client.IsWsConnected || (server.Clients != 1))
Thread.Yield();

byte[] malformedFrame = new byte[20];
malformedFrame[0] = 0x81;
malformedFrame[1] = 0xFF;

malformedFrame[2] = 0x0F;
for (int i = 3; i < 10; i++)
malformedFrame[i] = 0xFF;

// Set mask key (4 bytes)
malformedFrame[10] = 0x11;
malformedFrame[11] = 0x22;
malformedFrame[12] = 0x33;
malformedFrame[13] = 0x44;

client.Send(malformedFrame, 0, malformedFrame.Length);

Thread.Sleep(100);

Assert.True(client.CloseAsync(1000));
while (client.IsWsConnected || (server.Clients != 0))
Thread.Yield();

Assert.True(server.Stop());
while (server.IsStarted)
Thread.Yield();
}
}
}