-
-
Notifications
You must be signed in to change notification settings - Fork 6
regexp for require msgs in commit #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regexp for require msgs in commit #62
Conversation
Signed-off-by: Alexandre Perrin <[email protected]>
See cilium/cilium#23110 Signed-off-by: Alexandre Perrin <[email protected]>
Signed-off-by: Alexandre Perrin <[email protected]>
Signed-off-by: Alexandre Perrin <[email protected]>
Before this patch when running `make clean` we get:
make: *** No rule to make target 'rm', needed by 'clean'. Stop.
Signed-off-by: Alexandre Perrin <[email protected]>
| var cfg github.FlakeConfig | ||
| var cfg github.PRBlockerConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aanm is this breaking the current client mode workflow? I guess the FlakeConfig has now to be under flake-tracker:, is that a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine, client mode is meant for development purposes anyway.
| var cfg github.FlakeConfig | ||
| var cfg github.PRBlockerConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine, client mode is meant for development purposes anyway.
Add
regexpMsgtorequire-msgs-in-commit, a regular expression alternative tomsg. Also brings client mode support forrequire-msgs-in-commiton the way so I could manually test the patch.client mode tests
Got a complain when checking for a missing
msg:No complain on kaworu/cilium#283 for an existing
msg:Got an error when neither
msgorregexpMsgis configured:Complains about no
regexpMsgmatch:No complain on kaworu/cilium#277 when
regexpMsgmatches: