-
Notifications
You must be signed in to change notification settings - Fork 0
[CIVIS-11019] ubuntu 22.04 fips enabled base image for linuxserver #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 13 commits
6816e7c
7c0bda1
6b5e13e
de7f79e
1df1b47
1392b01
a9c8c78
fcfd50f
04c3978
9a8afff
615908a
bfe0aad
647ece9
b041b31
a2f07db
3a557ca
586b85a
7fad283
1e75063
23d5bd9
85e708b
198d925
3b8c1d5
b2bf51c
a7fa813
0733b58
3682f49
70f1c94
8f9669a
b69e351
6944ec6
78eac98
7a5b578
027f18f
30e14a4
7e01fa7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # ECR Configuration for FIPS Base Image | ||
| ECR_ACCOUNT_ID=0123456789012 | ||
thatguyinabeanie marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ECR_REGION=us-east-999 | ||
| BASE_IMAGE_NAME=ubuntu-fips | ||
| BASE_IMAGE_TAG=22.04 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,50 @@ | ||
| <!--- Provide a general summary of your changes in the Title above --> | ||
| ver_medium.png)][linuxserverurl] | ||
|
|
||
| [linuxserverurl]: https://linuxserver.io | ||
| [][linuxserverurl] | ||
| ut. We do not need a PR --> | ||
| ange for corner case functionality or plugins please look at making a Docker Mod or local script https://blog.linuxserver.io/2019/09/14/customizing-our-containers/ --> | ||
| message --> | ||
| --> | ||
| repository, please add your changes there if appropriate --> | ||
|
|
||
| TRIBUTING.md) guideline and understand that I have made the correct modifications | ||
|
|
||
| <!--- Before submitting a pull request please check the following --> | ||
| > | ||
thatguyinabeanie marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| <!--- If this is a fix for a typo (in code, documentation, or the README) please file an issue and let us sort it out. We do not need a PR --> | ||
| <!--- Ask yourself if this modification is something the whole userbase will benefit from, if this is a specific change for corner case functionality or plugins please look at making a Docker Mod or local script https://blog.linuxserver.io/2019/09/14/customizing-our-containers/ --> | ||
| <!--- That if the PR is addressing an existing issue include, closes #<issue number> , in the body of the PR commit message --> | ||
| <!--- You have included links to any files / patches etc your PR may be using in the body of the PR commit message --> | ||
| <!--- We maintain a changelog of major revisions to the container at the end of readme-vars.yml in the root of this repository, please add your changes there if appropriate --> | ||
| ## Description | ||
|
|
||
| Required: Please provide a brief description of what this pull request is trying to accomplish. | ||
|
|
||
| <!--- Coding guidelines: --> | ||
| <!--- 1. Installed packages in the Dockerfiles should be in alphabetical order --> | ||
| <!--- 2. Changes to Dockerfile should be replicated in Dockerfile.armhf and Dockerfile.aarch64 if applicable --> | ||
| <!--- 3. Indentation style (tabs vs 4 spaces vs 1 space) should match the rest of the document --> | ||
| <!--- 4. Readme is auto generated from readme-vars.yml, make your changes there --> | ||
| > | ||
| ------------------------------ | ||
| ## Context, Consequences, & Considerations | ||
|
|
||
| - [ ] I have read the [contributing](https://github.com/linuxserver/docker-baseimage-ubuntu/blob/jammy/.github/CONTRIBUTING.md) guideline and understand that I have made the correct modifications | ||
| Required: Please step through the following list, pausing at each item to consider your change in relation to the item's context. | ||
| Check the box to mark that it applies, and enter your relevant notes under the item. | ||
|
|
||
| ------------------------------ | ||
| - [ ] Security: This has security implications. This includes (but not limited to) adding users, modifying user/app permissions, network rules/policies, changing a system interconnection, or changing an authorization strategy. | ||
| - [ ] This PR does not require security review. These changes are part of a project plan that has already undergone security review. The link is provided below. | ||
| - [ ] This PR requires security review. Add the `security` label to this PR then request a review from the [Security Code Reviewers Team](https://github.com/orgs/civisanalytics/teams/security-code-reviewers). | ||
|
|
||
| <!--- We welcome all PR’s though this doesn’t guarantee it will be accepted. --> | ||
| > | ||
| ## Description: | ||
| <!--- Describe your changes in detail --> | ||
| - [ ] Execution: This change requires commands to be run outside of the normal merge. | ||
|
|
||
| ## Benefits of this PR and context: | ||
| <!--- Please explain why we should accept this PR. If this fixes an outstanding bug, please reference the issue # --> | ||
| > | ||
| ## How Has This Been Tested? | ||
| <!--- Please describe in detail how you tested your changes. --> | ||
| <!--- Include details of your testing environment, and the tests you ran to --> | ||
| <!--- see how your change affects other areas of the code, etc. --> | ||
| - [ ] Impact: This change may cause service interruptions. | ||
|
|
||
| > | ||
| ## Source / References: | ||
| <!--- Please include any forum posts/github links relevant to the PR --> | ||
| - [ ] Testing: How did you test this change (unit tests, acceptance tests, etc.)? Did you do any manual testing? | ||
|
|
||
| > | ||
| - [ ] Testing: How will you confirm this change once it's merged? | ||
|
|
||
| > | ||
| - [ ] Documentation: Documentation to reflect this change has been added to Confluence or Zendesk. | ||
|
|
||
| > | ||
| - [ ] **All items of the checklist have been considered and this PR description is complete.** | ||
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,3 +42,4 @@ Network Trash Folder | |
| Temporary Items | ||
| .apdisk | ||
| .jenkins-external | ||
| .env | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,65 +1,71 @@ | ||||||
| # syntax=docker/dockerfile:1 | ||||||
|
|
||||||
| FROM alpine:3 as rootfs-stage | ||||||
| # ECR and base image configuration | ||||||
| ARG ECR_ACCOUNT_ID=1234567890123 | ||||||
|
||||||
| ARG ECR_ACCOUNT_ID=1234567890123 | |
| ARG ECR_ACCOUNT_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why we're using a placeholder value here? I agree with copliot's suggestion (assuming this is not a real value).
What will supply these values for the real build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have removed the placeholder since i no longer need it. i've learned some neat things while working across these 3 repos, but in between when figuring stuff out, it was easier to just have a placeholder than to leave it blank. i've since moved a few things into the docker-compose.yml file so its gone from here now.
i'm gunna do a broader knowledge share on the work i did here because i think its neat and worth sharing.
Uh oh!
There was an error while loading. Please reload this page.