-
Notifications
You must be signed in to change notification settings - Fork 1
[CIVIS-11461] Add example with environment variables compatible with civis studios #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gskifstad
wants to merge
7
commits into
main
Choose a base branch
from
CIVIS-11461-add-code-cloud-compatible-dbt-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a8a945d
add example with environment variables compatible with code clouds
gskifstad 64fc888
add missing quotes
gskifstad 80fca8e
merge code_cloud_profiles.yml with profiles.yml
gskifstad 7272ba0
update readme
gskifstad b3068dd
fallback to none for cases where env var names are very different
gskifstad ccc773d
try empty string instead of none
gskifstad 13ede44
rename to studio; properly handle if/else cases for user, pass, dbnam…
gskifstad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this profile works for redshift in studios and platform dbt scripts! but im not sure if it is worth publishing? it is a bit complicated, but could be helpful.... I'd be curious if others find it readable or not.
options:
cc @leanne73 do you have thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can read it on my big monitor, but I was struggling to comprehend it from my laptop's smaller screen when looking at it last week lol.
I'm leaning towards moving both the studio examples to a separate profiles file? But after 11950, I think we'd only need the first example, which seems reasonable to keep in the same place as everything else...
lemme check with fessler and see if it looks like we'll be prioritizing CIVIS-11950 into an upcoming sprint. If so, then I think we just keep the simpler profile. Otherwise, it probably makes sense to keep them both, but maybe in a separate file.