Skip to content

Conversation

nicolas-dsk-claranet
Copy link
Contributor

No description provided.

@nicolas-dsk-claranet
Copy link
Contributor Author

Implementation of a workaround for the issue #587

@lionel-kaufmann-claranet
Copy link
Contributor

  • removed unused file
  • link filter to common aws one
  • Readme review

@lionel-kaufmann-claranet
Copy link
Contributor

There was a mistake in @nicolas-dsk-claranet diagnostic.
In the namespace amazonMQ we have the data of all the aws accounts, we definitly need to filter out the data for the environement, however the original mistake was that there is no collumn aws_account_id.

The filtering must be done on AWSUniqueId field. This field have a "special" format arn:aws:mq:<cluster_region>:<aws_account_id>:<cluster_name>
Put this format in the Readme file in order people to quickly understand how to fill this variable
Note that you find inside it the aws_account_id, that previous version focused on, but this was not enough.

Deployed on 3 environment, and working now, do not hesitate to contact Nicolas or me to give you the account for validation

Reviewers : do not undestand why tests are falling, as the content does not feat modules, I suspect a border effect due to tag change ( see files changed for the typo fix )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IMPROVE] Detector AmazonMQ RabbitMQ

2 participants