fix(shared): Avoid trailing period after dashboard URL in key error messages - #9602
Draft
djgould wants to merge 1 commit into
Draft
fix(shared): Avoid trailing period after dashboard URL in key error messages#9602djgould wants to merge 1 commit into
djgould wants to merge 1 commit into
Conversation
…essages Terminals and dev overlays linkify the sentence period into the URL, producing a broken /last-active?path=api-keys. link. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 8eaab1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The missing/invalid key error messages ended a sentence immediately after
https://dashboard.clerk.com/last-active?path=api-keys. Terminals and dev overlays linkify the trailing period into the URL, producing?path=api-keys., which the dashboard fails to resolve — users land on /apps instead of the API Keys page. PostHog shows ~13% of error-link clicks hit the broken variant.Rewords the four affected strings in
@clerk/shared(errorThrower.ts,keys.ts) so the URL sits mid-sentence with a trailing word absorbing the period. No other runtime strings in the repo have a URL directly followed by sentence punctuation.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code