-
Notifications
You must be signed in to change notification settings - Fork 374
ci(repo): Version packages #6397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 Walkthrough""" WalkthroughThe changes remove multiple changeset files, including those documenting updates to Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (59)
💤 Files with no reviewable changes (15)
✅ Files skipped from review due to trivial changes (14)
🚧 Files skipped from review as they are similar to previous changes (30)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/nuxt/CHANGELOG.md (2)
13-23
: Example snippet contains API & variable inconsistencies.
- Nuxt handlers expose
event.context.auth()
(orgetAuth(event)
)—the snippet usesevent.locals.auth(...)
.auth
is assigned but later referenced asauthObject
.
Update for accuracy to avoid user confusion.- export default eventHandler(event => { - const auth = event.locals.auth({ acceptsToken: 'any' }); + export default eventHandler(event => { + const auth = event.context.auth({ acceptsToken: 'any' }); ... - if (authObject.tokenType === 'session_token') { + if (auth.tokenType === 'session_token') { ... - console.log('more specifically, a ' + authObject.tokenType); + console.log('more specifically, a ' + auth.tokenType);
3-26
: Consider adding integration tests for the new token-type paths.No accompanying tests were introduced in this PR.
Adding end-to-end tests that exerciseacceptsToken
permutations (single, array,'any'
) will guard against regressions in future auth changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/cool-guests-trade.md
(0 hunks)packages/nuxt/CHANGELOG.md
(1 hunks)packages/nuxt/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/cool-guests-trade.md
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/nuxt/package.json
packages/nuxt/CHANGELOG.md
packages/*/package.json
📄 CodeRabbit Inference Engine (.cursor/rules/global.mdc)
All publishable packages should be placed under the packages/ directory
packages/*/package.json
: All publishable packages must be located in the 'packages/' directory.
All packages must be published under the @clerk namespace on npm.
Semantic versioning must be used across all packages.
Files:
packages/nuxt/package.json
**/*
⚙️ CodeRabbit Configuration File
**/*
: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.Whenever reviewing a pull request, if there are any changes that could impact security, always tag
@clerk/security
in the PR.Security-impacting changes include, but are not limited to:
- Changes to authentication logic or mechanisms (e.g. login, session handling, token issuance)
- Any modification to access control, authorization checks, or role-based permissions
- Introduction or modification of hashing algorithms, signature verification, or cryptographic primitives
- Handling of sensitive data (e.g. passwords, tokens, secrets, PII)
- Integration with external identity providers (e.g. SSO, OAuth, OpenID Connect)
- Modifications to security headers, cookie flags, CORS policies, or CSRF protections
- Bypass mechanisms (e.g. feature flags, testing overrides) that could weaken protections
- Changes to rate limiting, abuse prevention, or input validation
If you're unsure whether a change is security-relevant, err on the side of caution and tag
@clerk/security
.Any time that you tag
@clerk/security
, please do so explicitly in a code comment, rather than within a collapsed section in a coderabbit comment, such as the "recent review details" section. If you do use the team name in any thinking or non-direct-code-comment content, it can be referred to as "clerk security team" to avoid accidentally printing the tag which sends a notification to the team.
Files:
packages/nuxt/package.json
packages/nuxt/CHANGELOG.md
packages/**/CHANGELOG.md
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Maintain detailed changelogs
Files:
packages/nuxt/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Publish with pkg-pr-new
- GitHub Check: Unit Tests (22, **)
- GitHub Check: Static analysis
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep/ci
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
packages/nuxt/package.json (1)
3-3
: Semantic version bump looks correct—please double-check internal peer ranges.The jump from
1.7.14
→1.8.0
follows semver for a minor feature addition.
Before publishing, verify that any"peerDependencies"
or workspace ranges expecting^1.7.x
still resolve to1.8.0
, otherwise downstream installs may warn.packages/nuxt/CHANGELOG.md (1)
5-8
: Machine-auth support is security-sensitive—ensure dedicated review.The new token types (
api_key
,oauth_token
,machine_token
) expand the attack surface around authentication.
Recommend a focused security review of validation logic, token provenance, and ACL handling before release.@clerk/security
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
14862f1
to
4008047
Compare
4008047
to
4877388
Compare
4877388
to
dc2751a
Compare
dc2751a
to
97bb736
Compare
97bb736
to
5154cac
Compare
5154cac
to
5dd1fbd
Compare
5dd1fbd
to
27113fb
Compare
27113fb
to
052e15e
Compare
052e15e
to
513ab8a
Compare
513ab8a
to
2a704f0
Compare
2a704f0
to
a4acf4b
Compare
a4acf4b
to
d056432
Compare
3de64db
to
17a75df
Compare
17a75df
to
e9e67e2
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@clerk/[email protected]
Minor Changes
[Billing Beta]: Replace
org
fororganization
as payer type for billing APIs. (#6423) by @panteliselefThis applies for all billing APIs, except the resources classes that represent data from Frontend API.
Refactor base theme approach to enable opting into simple theme. (#6371) by @alexcarpenter
Patch Changes
Fixes an issue where cookies were not properly cleared on sign out when using non-default cookie attributes. (#6368) by @brkalow
Make
.finalize()
from useCheckout to return a Promise. (#6422) by @panteliselefFix server-side session cache not being invalidated for after-auth custom flows (#6425) by @LauraBeatris
Improve CLS when PaymentElement mounts in Checkout. (#6387) by @panteliselef
Updated dependencies [
e404456
,2803133
,f1d9d34
,d58b959
,822ba1f
,d4d2612
]:@clerk/[email protected]
Minor Changes
<RedirectToTask />
component (#6416) by @LauraBeatrisPatch Changes
e404456
,2803133
,f1d9d34
,0bdd0df
,d58b959
,232d7d3
,f6375f0
,822ba1f
,af615b8
,d4d2612
]:@clerk/[email protected]
Minor Changes
Introduces machine authentication, supporting four token types:
api_key
,oauth_token
,machine_token
, andsession_token
. For backwards compatibility,session_token
remains the default when no token type is specified. This enables machine-to-machine authentication and use cases such as API keys and OAuth integrations. Existing applications continue to work without modification. (#6391) by @wobsorianoYou can specify which token types are allowed by using the
acceptsToken
option in theevent.context.auth()
context. This option can be set to a specific type, an array of types, or'any'
to accept all supported tokens.Example usage:
Patch Changes
e404456
,2803133
,f1d9d34
,0bdd0df
,d58b959
,232d7d3
,f6375f0
,822ba1f
,af615b8
,d4d2612
]:@clerk/[email protected]
Minor Changes
<RedirectToTask />
component (#6416) by @LauraBeatrisPatch Changes
e404456
,2803133
,f1d9d34
,d58b959
,822ba1f
,d4d2612
]:@clerk/[email protected]
Minor Changes
[Billing Beta]: Replace
org
fororganization
as payer type for billing APIs. (#6423) by @panteliselefThis applies for all billing APIs, except the resources classes that represent data from Frontend API.
Patch Changes
Improve layout behaviour with
<PaymentElement fallback={} />
. (#6387) by @panteliseleffallback
prop.Fixes an issue where cookies were not properly cleared on sign out when using non-default cookie attributes. (#6368) by @brkalow
Updated dependencies [
e404456
,d58b959
,822ba1f
,d4d2612
]:@clerk/[email protected]
Minor Changes
[Billing Beta]: Replace
org
fororganization
as payer type for billing APIs. (#6423) by @panteliselefThis applies for all billing APIs, except the resources classes that represent data from Frontend API.
Refactor base theme approach to enable opting into simple theme. (#6371) by @alexcarpenter
Patch Changes
Update JSDocs for
SessionTask
to align with Clerk documentation (#6396) by @LauraBeatrisMake
.finalize()
from useCheckout to return a Promise. (#6422) by @panteliselef@clerk/[email protected]
Minor Changes
<RedirectToTask />
component (#6416) by @LauraBeatrisPatch Changes
e404456
,2803133
,f1d9d34
,d58b959
,822ba1f
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,0bdd0df
,d58b959
,232d7d3
,822ba1f
,af615b8
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,0bdd0df
,d58b959
,232d7d3
,822ba1f
,af615b8
,d4d2612
]:@clerk/[email protected]
Patch Changes
Adds scoping and secret key retrieval to machines BAPI methods: (#6417) by @wobsoriano
Fix SAML Connection
attributeMapping
keys not being converted from camelCase to snake_case. (#6418) by @tmilewskiFixes an issue where the Clerk SDK was improperly detecting the request's origin. (#6393) by @brkalow
Updated dependencies [
e404456
,2803133
,f1d9d34
,d58b959
,822ba1f
,d4d2612
]:@clerk/[email protected]
Patch Changes
2803133
,f1d9d34
,d58b959
,8fadb1d
,f6375f0
,822ba1f
,2803133
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,d58b959
,f6375f0
,822ba1f
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,d58b959
,8fadb1d
,f6375f0
,822ba1f
,2803133
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,d58b959
,822ba1f
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,0bdd0df
,d58b959
,232d7d3
,822ba1f
,af615b8
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,0bdd0df
,d58b959
,232d7d3
,822ba1f
,af615b8
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,d58b959
,822ba1f
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,0bdd0df
,d58b959
,232d7d3
,f6375f0
,822ba1f
,af615b8
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,0bdd0df
,d58b959
,232d7d3
,f6375f0
,822ba1f
,af615b8
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,0bdd0df
,d58b959
,232d7d3
,f6375f0
,822ba1f
,af615b8
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,2803133
,f1d9d34
,0bdd0df
,d58b959
,232d7d3
,822ba1f
,af615b8
,d4d2612
]:@clerk/[email protected]
Patch Changes
e404456
,d58b959
,822ba1f
,d4d2612
]:Summary by CodeRabbit
New Features
<RedirectToTask />
component in Next.js, React, and Vue packages.Bug Fixes
Improvements
organization
instead oforg
as payer type.Chores