Skip to content

fix(types, clerk-js): Update Errors interface to allow null for raw and global error arrays #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2025
Merged

fix(types, clerk-js): Update Errors interface to allow null for raw and global error arrays #6677

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2affab
fix(types, clerk-js): Update Errors interface to allow null for raw a…
nikosdouvlis Sep 1, 2025
72f1c15
fix(types, react): Update defaultErrors to set raw and global to null
nikosdouvlis Sep 2, 2025
12c508d
Merge branch 'main' into nikos/change-global-errors-type
nikosdouvlis Sep 3, 2025
89b099d
Update Errors interface to allow null values
nikosdouvlis Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions packages/clerk-js/src/core/signals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,30 +52,38 @@ function errorsToParsedErrors(error: unknown): Errors {
captcha: null,
legalAccepted: null,
},
raw: [],
global: [],
raw: null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate that this is the case, but we need to update the default errors in the state proxy in clerk-react as well 😭

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Ill try to prioritize some tests to catch these sooner and a (potential) refactor later. Fixing...

global: null,
};

if (!error) {
return parsedErrors;
}

if (!isClerkAPIResponseError(error)) {
parsedErrors.raw.push(error);
parsedErrors.global.push(error);
parsedErrors.raw = [error];
parsedErrors.global = [error];
return parsedErrors;
}

parsedErrors.raw.push(...error.errors);

error.errors.forEach(error => {
if (parsedErrors.raw) {
parsedErrors.raw.push(error);
} else {
parsedErrors.raw = [error];
}

if ('meta' in error && error.meta && 'paramName' in error.meta) {
const name = snakeToCamel(error.meta.paramName);
parsedErrors.fields[name as keyof typeof parsedErrors.fields] = error;
return;
}

parsedErrors.global.push(error);
if (parsedErrors.global) {
parsedErrors.global.push(error);
} else {
parsedErrors.global = [error];
}
});

return parsedErrors;
Expand Down
4 changes: 2 additions & 2 deletions packages/types/src/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ interface FieldErrors {

export interface Errors {
fields: FieldErrors;
raw: unknown[];
global: unknown[]; // does not include any errors that could be parsed as a field error
raw: unknown[] | null;
global: unknown[] | null;
}

export interface SignInSignal {
Expand Down
Loading