chore(repo): Remove unused TanStack Router tests #6955

wobsoriano · 2025-10-10T00:06:23Z

Description

We decided to not support TanStack Router apps with our TanStack Start SDK and they should be using our @clerk/react SDK for TanStack Router apps instead

See the TanStack Start DX Guide for more info

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Summary by CodeRabbit

New Features
- None
Chores
- Removed the TanStack React Router integration and its associated template content.
Tests
- Removed TanStack React Router integration tests and its CI/test-run entry.
Documentation
- Removed example instructions and README content for the TanStack React Router template.
Notes
- No changes to other integrations or core functionality.

changeset-bot · 2025-10-10T00:06:27Z

🦋 Changeset detected

Latest commit: 726bac9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-10-10T00:06:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
clerk-js-sandbox	Ready	Preview	Comment	Oct 21, 2025 5:27pm

coderabbitai · 2025-10-10T00:06:53Z

Walkthrough

Removes the TanStack React Router integration template, its files, presets export, tests, CI/Turbo entries, and npm script. Adds a placeholder changeset file.

Changes

Cohort / File(s)	Summary of changes
Changeset placeholder `.changeset/empty-elephants-push.md`	Added a changeset file containing front-matter separators (`---`).
CI matrix update `.github/workflows/ci.yml`	Removed `tanstack-react-router` from the `integration-tests` matrix.
TanStack preset export change `integration/presets/tanstack.ts`	Removed the `reactRouter` configuration and its export; `tanstack` now exports only `reactStart`.
Templates index pruning `integration/templates/index.ts`	Removed the `'tanstack-react-router'` entry from the exported `templates` map.
Remove TanStack React Router template files `integration/templates/tanstack-react-router/*`	Deleted the template directory and files: `index.html`, `package.json`, `src/main.tsx`, `src/routeTree.gen.ts`, `src/routes/__root.tsx`, `src/routes/index.tsx`, `src/routes/sign-in.tsx`, `tsconfig*.json`, `vite.config.js`, `.gitignore`, `README.md`.
Integration tests removal `integration/tests/tanstack-router/basic.test.ts`	Deleted the Playwright integration test suite for TanStack Router.
NPM scripts cleanup `package.json`	Removed the `test:integration:tanstack-react-router` npm script.
Turbo pipeline cleanup `turbo.json`	Removed the `//#test:integration:tanstack-react-router` pipeline entry and its config.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I hop through folders, light and spry,
Retiring routes with a gentle sigh.
Templates folded, tests set free,
CI pruned tidy as can be.
My whiskers twitch — a cleaner tree. 🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title Check	❓ Inconclusive	The title "chore(repo): Remove TanStack Router tests" is specific and clearly references a real aspect of the changeset—several test-related files and configurations are indeed removed. However, the primary scope of this PR extends significantly beyond tests: it removes the entire TanStack Router integration including templates, presets, configuration files, and infrastructure (CI, Turbo config, npm scripts). While the title accurately describes one component being removed, it focuses on that narrow aspect rather than clearly conveying the main change, which is the removal of comprehensive TanStack Router support from the codebase.	Consider revising the title to better reflect the full scope of the change, such as "chore(repo): Remove TanStack Router integration and tests" or "chore(repo): Remove TanStack Router support" to make it immediately clear to teammates that this is a comprehensive removal rather than just test cleanup.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch rob/remove-tanstack-router-test

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4a1d748 and e734408.

📒 Files selected for processing (19)

.changeset/empty-elephants-push.md (1 hunks)
.github/workflows/ci.yml (0 hunks)
integration/presets/tanstack.ts (0 hunks)
integration/templates/index.ts (0 hunks)
integration/templates/tanstack-react-router/.gitignore (0 hunks)
integration/templates/tanstack-react-router/README.md (0 hunks)
integration/templates/tanstack-react-router/index.html (0 hunks)
integration/templates/tanstack-react-router/package.json (0 hunks)
integration/templates/tanstack-react-router/src/main.tsx (0 hunks)
integration/templates/tanstack-react-router/src/routeTree.gen.ts (0 hunks)
integration/templates/tanstack-react-router/src/routes/__root.tsx (0 hunks)
integration/templates/tanstack-react-router/src/routes/index.tsx (0 hunks)
integration/templates/tanstack-react-router/src/routes/sign-in.tsx (0 hunks)
integration/templates/tanstack-react-router/tsconfig.dev.json (0 hunks)
integration/templates/tanstack-react-router/tsconfig.json (0 hunks)
integration/templates/tanstack-react-router/vite.config.js (0 hunks)
integration/tests/tanstack-router/basic.test.ts (0 hunks)
package.json (0 hunks)
turbo.json (0 hunks)

💤 Files with no reviewable changes (18)

integration/templates/tanstack-react-router/README.md
turbo.json
integration/templates/index.ts
integration/tests/tanstack-router/basic.test.ts
.github/workflows/ci.yml
integration/presets/tanstack.ts
package.json
integration/templates/tanstack-react-router/tsconfig.json
integration/templates/tanstack-react-router/tsconfig.dev.json
integration/templates/tanstack-react-router/.gitignore
integration/templates/tanstack-react-router/src/routes/__root.tsx
integration/templates/tanstack-react-router/package.json
integration/templates/tanstack-react-router/vite.config.js
integration/templates/tanstack-react-router/src/main.tsx
integration/templates/tanstack-react-router/src/routeTree.gen.ts
integration/templates/tanstack-react-router/src/routes/sign-in.tsx
integration/templates/tanstack-react-router/src/routes/index.tsx
integration/templates/tanstack-react-router/index.html

🧰 Additional context used

📓 Path-based instructions (1)

.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

.changeset/empty-elephants-push.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Formatting | Dedupe | Changeset
GitHub Check: Build Packages
GitHub Check: Analyze (javascript-typescript)
GitHub Check: semgrep-cloud-platform/scan
GitHub Check: semgrep-cloud-platform/scan

.changeset/empty-elephants-push.md

pkg-pr-new · 2025-10-10T00:10:35Z

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6955

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6955

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6955

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6955

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6955

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6955

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6955

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6955

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6955

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6955

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6955

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6955

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6955

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6955

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6955

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6955

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6955

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6955

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6955

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6955

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6955

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6955

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6955

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6955

commit: 726bac9

chore(repo): Remove TanStack Router tests

f326e86

chore: empty changeset

e734408

clerk-cookie added actions integration labels Oct 10, 2025

vercel bot deployed to Preview October 10, 2025 00:08 View deployment

coderabbitai bot reviewed Oct 10, 2025

View reviewed changes

.changeset/empty-elephants-push.md Show resolved Hide resolved

wobsoriano marked this pull request as draft October 10, 2025 04:50

Merge branch 'main' into rob/remove-tanstack-router-test

28218d9

vercel bot deployed to Preview October 10, 2025 16:52 View deployment

wobsoriano marked this pull request as ready for review October 10, 2025 16:53

wobsoriano added 2 commits October 10, 2025 09:55

chore: trigger

efa2ca1

chore: placeholder changeset

378898b

vercel bot deployed to Preview October 10, 2025 16:58 View deployment

Merge branch 'main' into rob/remove-tanstack-router-test

fd4f8e2

vercel bot deployed to Preview October 14, 2025 21:10 View deployment

Merge branch 'main' into rob/remove-tanstack-router-test

c1e3b02

vercel bot deployed to Preview October 21, 2025 15:45 View deployment

wobsoriano added 2 commits October 21, 2025 09:34

chore: remove tanstack router from long running apps

1a08107

Merge branch 'main' into rob/remove-tanstack-router-test

a591a8b

wobsoriano changed the title ~~chore(repo): Remove TanStack Router tests~~ chore(repo): Remove unused TanStack Router tests Oct 21, 2025

vercel bot deployed to Preview October 21, 2025 16:36 View deployment

Merge branch 'main' into rob/remove-tanstack-router-test

726bac9

vercel bot deployed to Preview October 21, 2025 17:27 View deployment

alexcarpenter approved these changes Oct 21, 2025

View reviewed changes

tmilewski approved these changes Oct 21, 2025

View reviewed changes

wobsoriano merged commit 911ccbb into main Oct 21, 2025
39 checks passed

wobsoriano deleted the rob/remove-tanstack-router-test branch October 21, 2025 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(repo): Remove unused TanStack Router tests #6955

chore(repo): Remove unused TanStack Router tests #6955

Uh oh!

wobsoriano commented Oct 10, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

vercel bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

pkg-pr-new bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore(repo): Remove unused TanStack Router tests #6955

chore(repo): Remove unused TanStack Router tests #6955

Uh oh!

Conversation

wobsoriano commented Oct 10, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkg-pr-new bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wobsoriano commented Oct 10, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Oct 10, 2025 •

edited

Loading

vercel bot commented Oct 10, 2025 •

edited

Loading

coderabbitai bot commented Oct 10, 2025 •

edited

Loading

pkg-pr-new bot commented Oct 10, 2025 •

edited

Loading