- 
                Notifications
    
You must be signed in to change notification settings  - Fork 402
 
fix(clerk-js): Detect if user is signed in already #7037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            jacekradko
  wants to merge
  10
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
fix/detect-multisession-already-signed-in
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from 2 commits
      Commits
    
    
            Show all changes
          
          
            10 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      d9aa5bb
              
                fix(clerk-js): Detect if user is signed in already
              
              
                jacekradko a546210
              
                remove extranous comments
              
              
                jacekradko 291e79f
              
                changeset
              
              
                jacekradko cdbd2d8
              
                fix test setup
              
              
                jacekradko 71d2e6a
              
                integration tests
              
              
                jacekradko 670d98c
              
                PR feedback
              
              
                jacekradko a027d82
              
                ensure add account works
              
              
                jacekradko a2be4e4
              
                Merge branch 'main' into fix/detect-multisession-already-signed-in
              
              
                jacekradko e4e793f
              
                capture query param action in useRef
              
              
                jacekradko 8290ce5
              
                additional tweaks
              
              
                jacekradko File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -590,4 +590,111 @@ describe('SignInStart', () => { | |
| ); | ||
| }); | ||
| }); | ||
| 
     | 
||
| describe('Active session redirect', () => { | ||
| describe('multi-session mode', () => { | ||
| it('redirects to /choose when user has active sessions', async () => { | ||
| const { wrapper, fixtures } = await createFixtures(f => { | ||
| f.withEmailAddress(); | ||
| f.withMultiSessionMode(); | ||
| f.withUser({ | ||
| email_addresses: ['[email protected]'], | ||
| }); | ||
| }); | ||
| 
     | 
||
| fixtures.clerk.client.signedInSessions = [ | ||
| { | ||
| id: 'sess_123', | ||
| user: fixtures.clerk.user, | ||
| status: 'active', | ||
| } as any, | ||
| ]; | ||
| 
     | 
||
| render(<SignInStart />, { wrapper }); | ||
| 
     | 
||
| await waitFor(() => { | ||
| expect(fixtures.router.navigate).toHaveBeenCalledWith('choose'); | ||
| }); | ||
| }); | ||
| 
     | 
||
| it('redirects to /choose when user has multiple active sessions', async () => { | ||
| const { wrapper, fixtures } = await createFixtures(f => { | ||
| f.withEmailAddress(); | ||
| f.withMultiSessionMode(); | ||
| f.withUser({ | ||
| email_addresses: ['[email protected]'], | ||
| }); | ||
| }); | ||
| 
     | 
||
| fixtures.clerk.client.signedInSessions = [ | ||
| { | ||
| id: 'sess_123', | ||
| user: fixtures.clerk.user, | ||
| status: 'active', | ||
| } as any, | ||
| { | ||
| id: 'sess_456', | ||
| user: { id: 'user_456' }, | ||
| status: 'active', | ||
| } as any, | ||
| ]; | ||
| 
     | 
||
| render(<SignInStart />, { wrapper }); | ||
| 
     | 
||
| await waitFor(() => { | ||
| expect(fixtures.router.navigate).toHaveBeenCalledWith('choose'); | ||
| }); | ||
| }); | ||
| 
     | 
||
| it('does NOT redirect when user has no active sessions', async () => { | ||
| const { wrapper, fixtures } = await createFixtures(f => { | ||
| f.withEmailAddress(); | ||
| f.withMultiSessionMode(); | ||
| }); | ||
| 
     | 
||
| fixtures.clerk.client.signedInSessions = []; | ||
| 
     | 
||
| render(<SignInStart />, { wrapper }); | ||
| 
     | 
||
| await waitFor( | ||
| () => { | ||
| expect(fixtures.router.navigate).not.toHaveBeenCalledWith('choose'); | ||
| }, | ||
| { timeout: 100 }, | ||
| ); | ||
| 
     | 
||
| screen.getByText(/email address/i); | ||
| }); | ||
| }); | ||
| 
     | 
||
| describe('single-session mode', () => { | ||
| it('does NOT redirect to /choose when user has active session in single-session mode', async () => { | ||
| const { wrapper, fixtures } = await createFixtures(f => { | ||
| f.withEmailAddress(); | ||
| f.withUser({ | ||
| email_addresses: ['[email protected]'], | ||
| }); | ||
| }); | ||
| 
     | 
||
| fixtures.clerk.client.signedInSessions = [ | ||
| { | ||
| id: 'sess_123', | ||
| user: fixtures.clerk.user, | ||
| status: 'active', | ||
| } as any, | ||
| ]; | ||
| 
     | 
||
| fixtures.environment.authConfig.singleSessionMode = true; | ||
| 
     | 
||
| render(<SignInStart />, { wrapper }); | ||
| 
     | 
||
| await waitFor( | ||
| () => { | ||
| expect(fixtures.router.navigate).not.toHaveBeenCalledWith('choose'); | ||
| }, | ||
| { timeout: 100 }, | ||
| ); | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.