Enable adding columns in auto migrations in schema crate
#2956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
force-pushed
the
jgilles/add_columns
branch
from
5268953 to
1814483
Compare
Shubham8287
reviewed
Jul 23, 2025
Shubham8287
force-pushed
the
jgilles/add_columns
branch
from
1814483 to
364e617
Compare
Centril
requested changes
Jul 28, 2025
Shubham8287
force-pushed
the
jgilles/add_columns
branch
3 times, most recently
from
075fa8f to
165df33
Compare
Shubham8287
force-pushed
the
jgilles/add_columns
branch
from
165df33 to
4bd8ce7
Compare
Centril
reviewed
Aug 11, 2025
Centril
reviewed
Aug 13, 2025
Shubham8287
force-pushed
the
jgilles/add_columns
branch
from
a792b32 to
608efaf
Compare
|
@Centril , Do you expect me to do anything else in this PR? |
If you could please address this: #2956 (comment) |
Centril
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This adds auto migration support to the
schemacrate.Additional changes are needed to fully implement this feature: see #2912
API and ABI breaking changes
None
Expected complexity level and risk
1, at this level the change is fairly straightforward. The integration will be more difficult.
Testing
Added
schemaunit tests for success/failure cases.