Add proper V8 sys module versioning #3527
Merged
+306
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/v8-sys-versioning
branch
2 times, most recently
from
9b221cf to
94b6c5e
Compare
Centril
reviewed
Oct 30, 2025
Co-authored-by: Mazdak Farrokhzad <[email protected]> Signed-off-by: Noa <[email protected]>
coolreader18
force-pushed
the
noa/v8-sys-versioning
branch
from
6748ebd to
9d71548
Compare
Centril
approved these changes
Nov 3, 2025
… into noa/v8-sys-versioning
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
# Description of Changes Currently need changes from both #3548 and #3527, and the latter is merged into master but the former isn't rebased on top of it. so we stay silly for the moment I'd like to pull out my first commit into its own PR, but that's not really possible until #3548 rebases onto master. # Expected complexity level and risk 2 - pretty straightforward translation of the wasm/Rust view implementation to typescript. # Testing - [ ] <!-- maybe a test you want to do --> - [ ] <!-- maybe a test you want a reviewer to do, so they can check it off when they're satisfied. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The previous
syscall.rsis now insyscall/v1.rs, and there's proper parsing of the[email protected]version number done now. This lets us more easily extend the ABI in the future.I also changed how slots are stored in the Context embedder data, to make it easier to add more in the future and more performant to fetch them.
Expected complexity level and risk
1
Testing
n/a, reorganization