Shub/view interface #3561
Merged
Shub/view interface #3561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
commented
Nov 3, 2025
| }) | ||
| } | ||
|
|
||
| /// Get or insert view argument into `ST_VIEW_ARG_ID`. |
There was a problem hiding this comment.
Moved it to mut_tx.rs
Shubham8287
commented
Nov 3, 2025
| ) | ||
| .await | ||
| .map_err(log_and_500)??; | ||
| tracing::info!(sql = body); |
There was a problem hiding this comment.
sql::execute::run is async now, hence made this code fuctional from closure.
Shubham8287
commented
Nov 3, 2025
| LifecycleReducer(Lifecycle), | ||
| } | ||
|
|
||
| pub struct ViewCallResult { |
Shubham8287
force-pushed
the
shub/view-interface
branch
from
299ad96 to
7a6eb54
Compare
Shubham8287
added a commit
that referenced
this pull request
Nov 6, 2025
Addresses - #3487 (comment). Can be reviewed commit wise. 1. Provide `ModuleSubscriptions` a interface to invoke `ModuleHost::call_view`. 2. Handle `st_view_client table` insertion. 3. Make views available form sql.
Shubham8287
added a commit
that referenced
this pull request
Nov 6, 2025
Addresses - #3487 (comment). Can be reviewed commit wise. 1. Provide `ModuleSubscriptions` a interface to invoke `ModuleHost::call_view`. 2. Handle `st_view_client table` insertion. 3. Make views available form sql.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Addresses - #3487 (comment).
Can be reviewed commit wise.
ModuleSubscriptionsa interface to invokeModuleHost::call_view.st_view_client tableinsertion.Testing
TODO