Skip to content

Dockerfile fails more cleanly if .git is a submodule #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
+9 −0
Merged

Dockerfile fails more cleanly if .git is a submodule #3591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7fe995
[bfops/fix-dockerfile]: Fix dockerfile
bfops Nov 6, 2025
58336ed
Merge branch 'master' into bfops/fix-dockerfile
bfops Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ FROM rust:bookworm AS builder
WORKDIR /usr/src/app
COPY . .

# If we're in a git submodule, we'll have a corrupted/nonfunctional .git file instead of a proper .git directory.
# To make the errors more sane, remove .git entirely.
RUN if [ -f .git ]; then \
echo "❌ ERROR: .git is a file (likely a submodule pointer), not a directory." >&2; \
echo "This will cause errors in the build process, because git operations will fail." >&2; \
echo "To address this, replace the .git file with a proper .git directory." >&2; \
exit 1; \
fi

RUN cargo build -p spacetimedb-standalone -p spacetimedb-cli --release --locked

FROM rust:bookworm
Expand Down
Loading