Update pre-commit and linting

.ansible-lint

@@ -0,0 +1,19 @@
+# Copyright 2025 Cloudera, Inc. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# profile: safety
+quiet: true
+strict: false
+verbosity: 0
+offline: true

.config/molecule/config.yml

@@ -1,3 +1,4 @@
+---
 # Copyright 2024 Cloudera, Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

.github/workflows/ansible-lint.yml

@@ -0,0 +1,60 @@
+---
+# Copyright 2025 Cloudera, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Lint Collection
+
+on:
+  pull_request:
+  push:
+    branches: [main, devel]
+jobs:
+  pre-commit:
+    name: Execute ansible-lint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+
+      - name: Set up Ansible
+        run: |
+          sudo update-alternatives --install /usr/bin/python python $(which python3) 1
+          python -m pip install --upgrade pip
+          python -m pip install "ansible-core<2.17" ansible-builder bindep pycodestyle voluptuous pylint pyyaml
+
+      - name: Install Ansible collections and roles
+        run: |
+          mkdir -p /usr/share/ansible/collections /usr/share/ansible/roles
+          ansible-galaxy collection install . -p /usr/share/ansible/collections
+          ansible-galaxy collection install -r requirements.yml -p /usr/share/ansible/collections
+          ansible-galaxy role install -r requirements.yml -p /usr/share/ansible/roles
+
+      - name: Set up Ansible collection dependencies
+        run: |
+          ansible-builder introspect --write-pip final_python.txt --write-bindep final_bindep.txt /usr/share/ansible/collections
+          [[ -f final_python.txt ]] && pip install -r final_python.txt || echo "No Python dependencies found."
+          [[ -f final_bindep.txt ]] && bindep --file final_bindep.txt || echo "No system dependencies found."
+
+      - name: Run ansible-lint
+        uses: ansible/ansible-lint@main
+        with:
+          setup_python: false
+        env:
+          ANSIBLE_COLLECTION_PATHS: /usr/share/ansible/collections
+          ANSIBLE_ROLE_PATHS: /usr/share/ansible/roles

.github/workflows/label_pr.yml

@@ -55,7 +55,7 @@ jobs:
             let fs = require('fs');
             fs.writeFileSync(`${process.env.GITHUB_WORKSPACE}/pr_number.zip`, Buffer.from(download.data));
 
-      - name: 'Unzip artifact'
+      - name: "Unzip artifact"
         run: unzip pr_number.zip
 
       - name: Read the PR number

.github/workflows/pre-commit.yml

@@ -1,4 +1,5 @@
-# Copyright 2024 Cloudera, Inc.
+---
+# Copyright 2025 Cloudera, Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -12,17 +13,48 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-name: Execute Precommit Linting and Checks
+name: Check Collection
 
 on:
   pull_request:
   push:
     branches: [main, devel]
-
 jobs:
   pre-commit:
+    name: Execute pre-commit
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v4
-    - uses: actions/setup-python@v5
-    - uses: pre-commit/[email protected]
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+
+      - name: Set up pre-commit and Ansible
+        run: |
+          # sudo update-alternatives --install /usr/bin/python python $(which python3) 1
+          python -m pip install --upgrade pip
+          python -m pip install pre-commit
+          # python -m pip install "ansible-core<2.17" ansible-builder bindep pycodestyle voluptuous pylint pyyaml ansible-lint
+
+      # - name: Install Ansible collections and roles
+      #   run: |
+      #     mkdir -p /usr/share/ansible/collections /usr/share/ansible/roles
+      #     ansible-galaxy collection install . -p /usr/share/ansible/collections
+      #     ansible-galaxy collection install -r requirements.yml -p /usr/share/ansible/collections
+      #     ansible-galaxy role install -r requirements.yml -p /usr/share/ansible/roles
+
+      # - name: Set up Ansible collection dependencies
+      #   run: |
+      #     ansible-builder introspect --write-pip final_python.txt --write-bindep final_bindep.txt /usr/share/ansible/collections
+      #     [[ -f final_python.txt ]] && pip install -r final_python.txt || echo "No Python dependencies found."
+      #     [[ -f final_bindep.txt ]] && bindep --file final_bindep.txt || echo "No system dependencies found."
+
+      - name: Run pre-commit
+        run: |
+          pre-commit run -a --show-diff-on-failure --color=always
+        # env:
+        #   ANSIBLE_COLLECTION_PATHS: /usr/share/ansible/collections
+        #   ANSIBLE_ROLE_PATHS: /usr/share/ansible/roles

.github/workflows/publish_docs.yml

@@ -19,10 +19,9 @@ name: Publish documentation
 on:
   push:
     branches:
-      - 'main'
+      - "main"
 
   workflow_dispatch:
-
 jobs:
   build-ansible-docs:
     name: Build Ansible Docs

.github/workflows/publish_galaxy.yml

@@ -19,7 +19,6 @@ name: Publish to Ansible Galaxy
 on:
   release:
     types: [published]
-
 jobs:
   galaxy_release:
     runs-on: ubuntu-latest

.github/workflows/reset_pr.yml

@@ -23,9 +23,9 @@ on:
       - synchronize
       - ready_for_review
     branches:
-      - 'release/**'
-      - 'devel'
-      - 'devel-pvc-base'
+      - "release/**"
+      - "devel"
+      - "devel-pvc-base"
 
 jobs:
   reset:

.github/workflows/validate_pr.yml

@@ -19,8 +19,8 @@ name: Validate Pull Request
 on:
   pull_request:
     branches:
-      - 'release/**'
-      - 'devel'
+      - "release/**"
+      - "devel"
 
 jobs:
   validate:
@@ -32,8 +32,8 @@ jobs:
       - name: Setup Python and caching
         uses: actions/setup-python@v4
         with:
-          python-version: '3.9'
-          cache: 'pip'
+          python-version: "3.9"
+          cache: "pip"
 
       - name: Set up Ansible collections
         run: |
@@ -59,7 +59,7 @@ jobs:
       - name: Report installed Python dependencies
         run: pip freeze
 
-      - name: Validate collection
+      - name: Test collection
         run: |
           pushd /usr/share/ansible/collections/ansible_collections/cloudera/exe
           #ansible-lint

.github/workflows/validate_pr_docs.yml

@@ -19,15 +19,14 @@ name: Validate Pull Request documentation
 on:
   pull_request:
     branches:
-      - 'release/**'
-      - 'devel'
+      - "release/**"
+      - "devel"
 
   workflow_dispatch:
-
 jobs:
   validate-docs:
     name: Validate Ansible Docs
-    uses: cloudera-labs/github-actions/.github/workflows/lint-ansible-docs.yml@v1
+    uses: cloudera-labs/github-actions/.github/workflows/lint-ansible-docs.yml@v2
     with:
       antsibull-log-upload: true
       collection-namespace: cloudera

.gitignore

@@ -164,3 +164,6 @@ cython_debug/
 
 # UV package manager
 uv.lock
+
+# Ansible tests
+.ansible

.pre-commit-config.yaml

@@ -1,4 +1,5 @@
-# Copyright 2024 Cloudera, Inc.
+---
+# Copyright 2025 Cloudera, Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -14,13 +15,40 @@
 
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v3.2.0
+    rev: v5.0.0
     hooks:
       - id: trailing-whitespace
       - id: end-of-file-fixer
       - id: check-yaml
+      - id: check-toml
+      - id: check-json
       - id: check-added-large-files
+      - id: check-case-conflict
+      - id: check-docstring-first
+      - id: check-merge-conflict
+      - id: check-symlinks
+      - id: debug-statements
+      - id: detect-aws-credentials
+        args:
+          - --allow-missing-credentials
+      - id: detect-private-key
+      - id: forbid-submodules
+      # - id: name-tests-test
+  - repo: https://github.com/asottile/add-trailing-comma.git
+    rev: v3.2.0
+    hooks:
+      - id: add-trailing-comma
+        name: ensure trailing commas
+        args:
+          - --py36-plus
   - repo: https://github.com/psf/black
-    rev: 22.10.0
+    rev: 25.1.0
     hooks:
       - id: black
+        name: lint python
+  # - repo: https://github.com/ansible/ansible-lint
+  #   rev: v25.6.1
+  #   hooks:
+  #     - id: ansible-lint
+  #       name: lint ansible
+  #       language: system