replace frozen crypto/pkcs12 library with software.sslmate.com/src/go-pkcs12 #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated build instructions
Updated README: make fails to install cfssl* binaries into bin directory
Creating Semgrep.yml file - Semgrep is a tool that will be used to scan Cloudflare's public repos for Supply chain, code and secrets. This work is part of Application & Product Security team's initiative to onboard Semgrep onto all of Cloudflare's public repos. In case of any questions, please reach out to "Hrushikesh Deshpande" on cf internal chat.
…e-creating-semgrep-yml Create semgrep.yml
…-transparency-go-bump Upgrade certificate-transparency-go from v1.1.8 to v1.3.1
This reverts commit 1a73d78.
…o-upgrade Revert "Upgrade certificate-transparency-go from v1.1.8 to v1.3.1"
…st-cases Mitch292/1237 fix test cases
Github actions linter uses [email protected]
Update repository to reflect required min go version of 1.20
…nore ignore .git to .dockerignore
…i1337/cfssl into dep/replace-pkcs12-library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with
cfssla bit, I've noticed that its not always possible to decode.p12- or.pfx-files due to the following error:While doing some research on this, I've found out, that the standard
crypto/pkcs12-pkg is currently in a somewhat frozen state:golang/go#62375
This PR suggests replacing the (currently) frozen
crypto/pkcs12with the drop-in-replacementhttps://github.com/SSLMate/go-pkcs12.I also had to rework the caCertificate-Handling a bit by using
DecodeChaininstead ofDecode, since its possible that the provided pfxData may also include the ca-certificate chain which would lead to an error when passed to a simpleDecode.Let me know what you think.
Thanks!