telemetry: remove Box::pin from WithTelemetryContext #133
+154
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqminh
force-pushed
the
telemetry-context-pin
branch
2 times, most recently
from
48f49c6 to
73ccf73
Compare
TheJokr
reviewed
Sep 4, 2025
foundations/Cargo.toml
Outdated
| @@ -230,6 +230,7 @@ log = { workspace = true, optional = true } | |||
| parking_lot_core = { workspace = true, optional = true } | |||
| regex = { workspace = true, optional = true } | |||
| thiserror = { workspace = true, optional = true } | |||
| pin-project = "1.1.10" | |||
There was a problem hiding this comment.
versions should go into the root Cargo.toml, this should only specify workspace = true. Also, for such simple cases pin-project-lite is preferable as it reduces compile times. (The latter is a macro_rules! while pin-project is a proc-macro.)
| @@ -23,6 +24,24 @@ feature_use!(cfg(feature = "tracing"), { | |||
| #[cfg(feature = "testing")] | |||
| use super::testing::TestTelemetryContext; | |||
|
|
|||
| #[pin_project] | |||
| pub struct WithTelemetryContextGeneric<T> { | |||
There was a problem hiding this comment.
please add a doc comment similar to WithTelemetryContextLocal
This allows user to skip the boxing step and save a memory allocation.
This is configure with `generic=true` in attribute. For example
```
#[span_fn("async_trait_span", generic = true)]
```
Also add a feature `generic-telemetry-wrapper` so user can enable this
behavior by default.
dqminh
force-pushed
the
telemetry-context-pin
branch
from
73ccf73 to
998ce3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In async heavy code, Box::pin contributes a large percentage of allocation time. We can switch to pin_project to remove Box::pin usage here.
This allows user to skip the boxing step and save a memory allocation.
This is configure with
generic=truein attribute. For example