Make directory for CloudConfig templates configurable by aramprice · Pull Request #65 · cloudfoundry/bosh-acceptance-tests

aramprice · 2026-07-16T22:29:40Z

See #64

linux-foundation-easycla · 2026-07-16T22:29:50Z

The committers listed above are authorized under a signed CLA.

✅ login: aramprice / name: aram price (701aea5)

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

aramprice · 2026-07-16T22:31:58Z

/easycla

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

aramprice · 2026-07-17T00:34:16Z

/easycla

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

coderabbitai · 2026-07-17T00:41:35Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 85357f69-e5c7-4e04-b399-62f7fe7f087f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

✅ Review completed - (🔄 Check again to review again)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch make-cc-templates-dir-configurable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

    OPTIONAL_VARS = {
      debug_mode:           'BAT_DEBUG_MODE',
+      cc_templates_dir:     'BAT_CC_TEMPLATES_DIR',
    }.freeze


a2geek · 2026-07-17T03:30:49Z

An update, for my part -- I've got it running against the LXD CPI with the BAT_CC_TEMPLATES_DIR environment variable and it seems to be running just fine!

Note that the README should also be updated as well.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lib/bat/cloud_config.rb`:
- Around line 71-80: Update cc_templates_dir to stop checking Dir.exist? for an
explicitly configured `@env.cc_templates_dir`. Preserve the existing non-empty
configuration check, return the configured path as-is, and retain
DEFAULT_TEMPLATES_DIR only when no path is configured.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2dbb0c82-2133-47eb-be5a-70d3d341ddfb

📥 Commits

Reviewing files that changed from the base of the PR and between 31057b3 and e64e438.

📒 Files selected for processing (6)

README.md
lib/bat/cloud_config.rb
lib/bat/env.rb
lib/bat/requirements.rb
spec/bat/requirements_spec.rb
spec/system/spec_helper.rb

coderabbitai · 2026-07-17T04:36:10Z

+
+    def cc_templates_dir
+      if @env.cc_templates_dir &&
+         @env.cc_templates_dir != "" &&
+         Dir.exist?(@env.cc_templates_dir)
+        @env.cc_templates_dir
+      else
+        DEFAULT_TEMPLATES_DIR
+      end
+    end


📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid silent fallbacks for explicit configurations.

If BAT_CC_TEMPLATES_DIR is explicitly set to a non-existent path, Dir.exist? evaluates to false and the code silently falls back to DEFAULT_TEMPLATES_DIR. This can lead to confusing test behavior where the default templates are used instead of custom ones, without warning the user.

Removing the Dir.exist? check allows File.read downstream to fail loudly with an Errno::ENOENT error indicating the exact path it attempted to read from, making misconfigurations much easier to debug.

♻️ Proposed fix

def cc_templates_dir - if `@env.cc_templates_dir` && - `@env.cc_templates_dir` != "" && - Dir.exist?(`@env.cc_templates_dir`) + if `@env.cc_templates_dir` && !`@env.cc_templates_dir.empty`? `@env.cc_templates_dir` else DEFAULT_TEMPLATES_DIR end end

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

def cc_templates_dir

if @env.cc_templates_dir &&

@env.cc_templates_dir != "" &&

Dir.exist?(@env.cc_templates_dir)

@env.cc_templates_dir

else

DEFAULT_TEMPLATES_DIR

end

end

def cc_templates_dir

if `@env.cc_templates_dir` && !`@env.cc_templates_dir.empty`?

`@env.cc_templates_dir`

else

DEFAULT_TEMPLATES_DIR

end

end

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@lib/bat/cloud_config.rb` around lines 71 - 80, Update cc_templates_dir to stop checking Dir.exist? for an explicitly configured `@env.cc_templates_dir`. Preserve the existing non-empty configuration check, return the configured path as-is, and retain DEFAULT_TEMPLATES_DIR only when no path is configured.

aramprice requested a review from Copilot July 16, 2026 22:29

Copilot started reviewing on behalf of aramprice July 16, 2026 22:30 View session

Copilot AI reviewed Jul 16, 2026

aramprice mentioned this pull request Jul 16, 2026

Custom cloud configs? #64

Open

aramprice requested a review from Copilot July 16, 2026 22:33

Copilot started reviewing on behalf of aramprice July 16, 2026 22:33 View session

Copilot AI reviewed Jul 16, 2026

cf-foundation-community-automation Bot added this to Foundational Infrastructure Working Group Jul 16, 2026

cf-foundation-community-automation Bot moved this to Inbox in Foundational Infrastructure Working Group Jul 16, 2026

aramprice requested a review from Copilot July 17, 2026 00:34

Copilot started reviewing on behalf of aramprice July 17, 2026 00:34 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread lib/bat/cloud_config.rb

Comment thread lib/bat/requirements.rb

aramprice force-pushed the make-cc-templates-dir-configurable branch from 701aea5 to bedfbc8 Compare July 17, 2026 00:41

coderabbitai Bot previously approved these changes Jul 17, 2026

View reviewed changes

github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jul 17, 2026

aramprice requested a review from Copilot July 17, 2026 00:43

Copilot started reviewing on behalf of aramprice July 17, 2026 00:43 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread lib/bat/cloud_config.rb Outdated

aramprice dismissed coderabbitai[bot]’s stale review via 78e0f55 July 17, 2026 00:51

aramprice force-pushed the make-cc-templates-dir-configurable branch from bedfbc8 to 78e0f55 Compare July 17, 2026 00:51

coderabbitai Bot previously approved these changes Jul 17, 2026

View reviewed changes

aramprice requested a review from Copilot July 17, 2026 00:51

Copilot started reviewing on behalf of aramprice July 17, 2026 00:51 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread lib/bat/env.rb

Comment on lines 11 to 14

OPTIONAL_VARS = {

debug_mode: 'BAT_DEBUG_MODE',

cc_templates_dir: 'BAT_CC_TEMPLATES_DIR',

}.freeze

Make directory for CloudConfig templates configurable

e64e438

aramprice dismissed coderabbitai[bot]’s stale review via e64e438 July 17, 2026 04:28

aramprice force-pushed the make-cc-templates-dir-configurable branch from 78e0f55 to e64e438 Compare July 17, 2026 04:28

aramprice requested a review from Copilot July 17, 2026 04:28

Copilot AI reviewed Jul 17, 2026

aramprice requested a review from rkoster July 17, 2026 04:30

coderabbitai Bot requested changes Jul 17, 2026

View reviewed changes

github-project-automation Bot moved this from Pending Merge | Prioritized to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Jul 17, 2026

Uh oh!

Conversation

aramprice commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

aramprice commented Jul 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

aramprice commented Jul 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

a2geek commented Jul 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aramprice commented Jul 16, 2026 •

edited

Loading

linux-foundation-easycla Bot commented Jul 16, 2026 •

edited

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading