Remove "Thin" webserver #4670
Open
Remove "Thin" webserver #4670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* preparation for Thin removal * replace EventMachine with Concurrent::TimerTask * remove "thread_info_event_machine" metrics
* explicitly start and stop MetricsWebserver with Prometheus middleware
* Rack expects an enumerable. An empty string doesn't work (it worked for Thin, though).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Remove the deprecated "Thin" webserver and also the "EventMachine" leftovers.
An explanation of the use cases your change solves
Removes deprecated Gems and coding.
Links to any other associated PRs
Roadmap for Thin removal #4115
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests