feat: adds the --instance-timeout flag to control timeout value#233
Open
feat: adds the --instance-timeout flag to control timeout value#233
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Service Management Working Group
pivotal-marcela-campo
approved these changes
Nov 21, 2025
| Entry("moderate interval", 100*time.Millisecond), | ||
| ) | ||
|
|
||
| When("the upgrade times out", func() { |
There was a problem hiding this comment.
thought: both tests use custom timeouts. which is understandable as we don't want to wait too much. It turns out to be a bit confusing when reading it. Also the second test (custom value) only tests one value, so we are not sure if it is testing the default or the custom. I suggest either adding more than one test to the custom timeout one below ( two different values and make sure we respect the two values) or grouping the two tests together and testing both the error message and timeout value in both of them.
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritised
in Service Management Working Group
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.