fix: update old metrics point after update

[mrdotb]

👋
#37

[jsilvela]

Good catch @mrdotb . Huh, the upstream deprecation was quite draconian. And your fix, I think, will not work for 1.25
Might be helpful if you added instead of modifying? So, have a metrics point for in-tree backups, and one for plugin backups? Could that make sense?

[mrdotb]

@jsilvela
I updated it to use a union query and check both metrics. Since we want a MAX(value), this seems to be the best solution, as we need the latest data regardless of the backup strategy.

I tested on my grafana it seems to work properly.

[jsilvela]

Nice. You may want to have a more useful description in case it can serve as the commit message.

[mrdotb]

I amended the commit with a bit more details.

[georgek]

Presumably given the naming the upstream would expose different metrics for different backup plugins. It doesn't seem like a sustainable solution to keep adding names for all possible backup plugins. Would it better to have the backup metrics configurable via chart values?

[JordanP]

Would it better to have the backup metrics configurable via chart values?

It's very convenient that this dashboard is usable without Helm. The resource here
https://raw.githubusercontent.com/cloudnative-pg/grafana-dashboards/main/charts/cluster/grafana-dashboard.json is a valid JSON.

[flokoe]

Hi there,

Presumably given the naming the upstream would expose different metrics for different backup plugins.

Are there any indications this will happen in the near future? For now, the Barman Cloud plugin seems to be the only plugin mentioned in the docs.

If there are no technical or qualitative reasons to hold this back, I would prefer it if this could be merged instead of dwelling on hypotheticals. The dashboard has been effectively broken for two releases.

[mrdotb]

Meanwhile you can deploy the dashboard using my fork it's just a json.

---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
configMapGenerator:
  - name: cloudnative-pg-dashboard
    files:
      - cloudnative-pg-dashboard.json=https://raw.githubusercontent.com/mrdotb/grafana-dashboards/3761c25bc51faf58026e9a892890b58089d2ced8/charts/cluster/grafana-dashboard.json
generatorOptions:
  disableNameSuffixHash: true
  annotations:
    kustomize.toolkit.fluxcd.io/substitute: disabled
  labels:
    grafana_dashboard: "1"