Allow for different KSM scraping job name #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unlikely that another scraping job than kube-state-metrics has the `kube_pod_container_resource_requests` metrics and if it does, the timeseries probably has the same meaning. So it's a bit redundant to filter kube_pod_container_resource_requests with `job="kube-state-metrics`. Some environments don't use `kube-state-metrics` as job name. For instance the Grafana K8s Monitoring Helm chart https://github.com/search?q=repo%3Agrafana%2Fk8s-monitoring-helm+%22integrations%2Fkubernetes%2Fkube-state-metrics%22&type=code `integrations/kubernetes/kube-state-metrics` Signed-off-by: Jordan Pittier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unlikely that another scraping job than kube-state-metrics has the
kube_pod_container_resource_requestsmetrics and if it does, the timeseries probably has the same meaning. So it's a bit redundant to filter kube_pod_container_resource_requests withjob="kube-state-metrics.Some environments don't use
kube-state-metricsas job name. For instance the Grafana K8s Monitoring Helm chart https://github.com/search?q=repo%3Agrafana%2Fk8s-monitoring-helm+%22integrations%2Fkubernetes%2Fkube-state-metrics%22&type=codeintegrations/kubernetes/kube-state-metrics