Skip to content

Choose a tag to compare

@github-actions github-actions released this 29 Nov 18:43
· 38 commits to refs/heads/main since this release
e2e648a
Add image_name parameter in case $org/$repo isn't acceptable @ozydingo (#27)

what

  • Adds an image_name input that can be specified if the default ${{ inputs.organization }}/${{ inputs.repository }} is not acceptable.

why

  • We have a use case where we build multiple targets from the same dockerfile in the same repo.
  • As currently abstracted, the image name will be the same for these: ${{ inputs.organization }}/${{ inputs.repository }}.
  • We hacked around this by modifying the value of inputs.repository to include the build target, but this is incorrect (and repository is used on one other place here)
  • We added a use case for which the above hack does not work -- two docker files, both using the default target.
  • It would be nice to support the underlying action's image_name as a pass-through.

references

  • Build using the new image_name var: link
  • Build using this branch without supplying image_name: link

I suspect tests are failing due to missing secrets in my fork, or something like that.