Skip to content

Added the output instance_class #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Added the output instance_class #111

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec9fce9
fix: added output cluster_members for resource aws_docdb_cluster
Faris96Hub Aug 20, 2024
d602b7b
fix: added flatten()
Faris96Hub Aug 26, 2024
f440ea7
Merge branch 'main' into main
Faris96Hub Sep 2, 2024
c0026e9
format
kevcube Sep 5, 2024
5e8fcaa
feature: added instance_class as an output
Faris96Hub Sep 25, 2024
240ec49
Merge remote-tracking branch 'origin/main'
Faris96Hub Sep 25, 2024
fd9ebec
Merge branch 'cloudposse:main' into main
Faris96Hub Sep 25, 2024
462fa7b
chore: adds final newline
Gowiem Sep 25, 2024
06c0eb0
fix: used the variable instance _class as the output to avoid the loop
Faris96Hub Sep 26, 2024
1e1de9c
Merge remote-tracking branch 'origin/main'
Faris96Hub Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,8 @@ output "security_group_name" {
description = "Name of the DocumentDB cluster Security Group"
value = join("", aws_security_group.default[*].name)
}

output "instance_class" {
description = "The instance calss used by the DocumentDB Cluster. For more details, see https://docs.aws.amazon.com/documentdb/latest/developerguide/db-instance-classes.html#db-instance-class-specs"
value = distinct([for instance in aws_docdb_cluster_instance.default : instance.instance_class])[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Faris96Hub how is this different from var.instance_class? Or is not different and you're using the default of that value, so you need it as an output? If the latter... can we just output var.instance_class instead of adding this looping logic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not using the default but using var.instance_class would be an option too, to avoid the loop. Ill change it

}