Skip to content

Removed bare default security group resource creation in favor of the… #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removed bare default security group resource creation in favor of the… #261

wants to merge 2 commits into from

Conversation

riccardomassullo
Copy link

… Cloudposse security group module.

what

  • Removed bare security group resource and security group rules resources in favor of Cloudposse Security Group module (cloudposse/security-group)

why

  • More compliance
  • Easier to read

references

The comment line inside main.tf (# TODO: Use cloudposse/security-group module)

@riccardomassullo riccardomassullo requested review from a team as code owners May 6, 2025 14:39
@mergify mergify bot added the triage Needs triage label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

triage Needs triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@riccardomassullo