Skip to content

Add seconds_until_auto_pause in serverlessv2_scaling_configuration #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add seconds_until_auto_pause in serverlessv2_scaling_configuration #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7110f59
add perfomace inside to primary cluster
djakielski Jan 3, 2025
e8a695f
refactor: run terraform fmt
RoseSecurity Jan 28, 2025
311edc3
Merge branch 'main' into main
nitrocode Feb 2, 2025
c26877f
Merge branch 'main' into main
RoseSecurity Feb 4, 2025
9fada4e
Merge branch 'cloudposse:main' into main
djakielski Jul 28, 2025
ced05b7
add auto_pause to variables.tf
djakielski Jul 28, 2025
e8248d8
add seconds_until_auto_pause to cluster
djakielski Jul 28, 2025
a54db38
Update main.tf
djakielski Jul 28, 2025
fb0c1ba
Update min aws versions
djakielski Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,9 @@ resource "aws_rds_cluster" "primary" {
dynamic "serverlessv2_scaling_configuration" {
for_each = var.serverlessv2_scaling_configuration[*]
content {
max_capacity = serverlessv2_scaling_configuration.value.max_capacity
min_capacity = serverlessv2_scaling_configuration.value.min_capacity
max_capacity = serverlessv2_scaling_configuration.value.max_capacity
min_capacity = serverlessv2_scaling_configuration.value.min_capacity
seconds_until_auto_pause = serverlessv2_scaling_configuration.value.seconds_until_auto_pause
}
}

Expand Down Expand Up @@ -290,8 +291,9 @@ resource "aws_rds_cluster" "secondary" {
dynamic "serverlessv2_scaling_configuration" {
for_each = var.serverlessv2_scaling_configuration[*]
content {
max_capacity = serverlessv2_scaling_configuration.value.max_capacity
min_capacity = serverlessv2_scaling_configuration.value.min_capacity
max_capacity = serverlessv2_scaling_configuration.value.max_capacity
min_capacity = serverlessv2_scaling_configuration.value.min_capacity
seconds_until_auto_pause = serverlessv2_scaling_configuration.value.seconds_until_auto_pause
}
}

Expand Down
1 change: 1 addition & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ variable "serverlessv2_scaling_configuration" {
type = object({
min_capacity = number
max_capacity = number
seconds_until_auto_pause = optional(number,0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be null if optional?
0 (zero) is not a valid value.

Image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

Suggested change
seconds_until_auto_pause = optional(number,0)
seconds_until_auto_pause = optional(number, null)

})
default = null
description = "serverlessv2 scaling properties"
Expand Down
2 changes: 1 addition & 1 deletion versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 5.61.0"
version = ">= 5.81.0"
}
null = {
source = "hashicorp/null"
Expand Down
Loading