Skip to content

Conversation

jogo
Copy link

@jogo jogo commented Mar 1, 2018

Tested with python 3.6

jogo and others added 16 commits February 14, 2018 10:53
Stop writing directly to a users homedir, so we don't leave random files
lying around if the user deletes the repo. Instead use the default .tox
location.
Newer versions of jingo and django-nose no longer work with older
versions of Django, so pin to get tests passing again.
Python2.6 is unsupported by all major distros. And Django stopped
supporting it in  Django 1.6.
In the travis env getting the following error:

...
  File "/home/travis/build/clouserw/tower/tower/tests/test_l10n.py", line 35, in setup
    tower.activate('xx')
  File "/home/travis/build/clouserw/tower/tower/__init__.py", line 104, in activate
    django_trans._active.value = _activate(locale)
  File "/home/travis/build/clouserw/tower/tower/__init__.py", line 130, in _activate
    t.set_language(locale)
AttributeError: NullTranslations instance has no attribute 'set_language'

This appears to related to https://code.djangoproject.com/ticket/18192
* Use Jingo 0.8 for Django 1.8
* As of django/django@a5f6cbc
  DjangoTranslation object won't work when passed into gettext.translation. So
  use default gettext.GNUTranslations just like Django
futurize -1 -w -n tower/

First step in adding python3 support.
Add future as a dependency

  futurize -2 -w -n tower/
str(pofile) wouldn't return the contents. So instead write to BytesIO
and read from there.

Add a tox endpoint for py36-1.8, Django 1-7 and below doesn't support
py35+
So https://github.com/brettcannon/caniusepython3 can be used to
programmatically detect this works with python 3.
Add compatibility with Django 1.9+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants