Skip to content

feat(bff): get floating-ip by ID - #535

Merged
vlad-schur-external-sap merged 5 commits into
mainfrom
vlad-get-floatingip-by-id
Mar 2, 2026
Merged

feat(bff): get floating-ip by ID#535
vlad-schur-external-sap merged 5 commits into
mainfrom
vlad-get-floatingip-by-id

Conversation

@vlad-schur-external-sap

@vlad-schur-external-sap vlad-schur-external-sap commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Summary

This implements the getById procedure to fetch the floating IP details so later we can display detailed information about a single floating IP on the corresponding page on the client network/floating-ips/$floatingIpId/index.tsx

Changes Made

  • Added getById procedure
  • Added corresponding tests
  • Removed unused network router

Related Issues

Testing Instructions

  1. pnpm i
  2. pnpm run test

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@vlad-schur-external-sap
vlad-schur-external-sap requested a review from a team as a code owner February 27, 2026 15:33
@vlad-schur-external-sap
vlad-schur-external-sap marked this pull request as draft February 27, 2026 15:33
@vlad-schur-external-sap vlad-schur-external-sap linked an issue Feb 27, 2026 that may be closed by this pull request
@vlad-schur-external-sap
vlad-schur-external-sap marked this pull request as ready for review March 1, 2026 21:12
Comment thread apps/aurora-portal/src/server/Network/routers/networkrouter.ts Outdated
andypf
andypf previously approved these changes Mar 2, 2026

@andypf andypf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@mark-karnaukh-extern-sap mark-karnaukh-extern-sap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlad-schur-external-sap nice! 🙂👍

@vlad-schur-external-sap
vlad-schur-external-sap merged commit ee89753 into main Mar 2, 2026
15 checks passed
@vlad-schur-external-sap
vlad-schur-external-sap deleted the vlad-get-floatingip-by-id branch March 2, 2026 10:23
@github-project-automation github-project-automation Bot moved this from In progress to Done in Aurora Roadmap Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement getById procedure in floatingIpRouter.ts

4 participants