feat(bff): get floating-ip by ID - #535
Merged
Merged
Conversation
vlad-schur-external-sap
requested review from
KirylSAP,
TilmanHaupt,
andypf and
mark-karnaukh-extern-sap
March 1, 2026 21:06
vlad-schur-external-sap
marked this pull request as ready for review
March 1, 2026 21:12
KirylSAP
reviewed
Mar 2, 2026
mark-karnaukh-extern-sap
approved these changes
Mar 2, 2026
mark-karnaukh-extern-sap
left a comment
Contributor
There was a problem hiding this comment.
@vlad-schur-external-sap nice! 🙂👍
andypf
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implements the getById procedure to fetch the floating IP details so later we can display detailed information about a single floating IP on the corresponding page on the client
network/floating-ips/$floatingIpId/index.tsxChanges Made
Related Issues
getByIdprocedure infloatingIpRouter.ts#523Testing Instructions
pnpm ipnpm run testChecklist