Skip to content

Conversation

sus-admin
Copy link
Contributor

Previous submission of this PR was not pretty ( https://github.com/cobbler/cobbler.github.io/pull/188/files ). Resubmitting, hopefully more readable

@sus-admin
Copy link
Contributor Author

@SchoolGuy I've closed my previous PR and resubmitted changes under this PR. Please have a look and let me know your thoughts.

Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks that I think are mostly taken over from the old PR. This version looks much better already though!

@sus-admin
Copy link
Contributor Author

@SchoolGuy fixed, although there were some slight adjustments I had to make to beginners guide, I had a duplicate note and one command was out of order a little. Ready for review. Happy new year, hope you had a nice holiday break!

@sus-admin sus-admin requested a review from SchoolGuy January 13, 2025 22:11
… the functions of the 'preseed_early_default' and 'preseed_late_default' that come standard with Cobbler for Debian autoinstalls by merging in my workaround (pre-installation) and post-installation changes into new scripts to be used in the preseed
@sus-admin
Copy link
Contributor Author

@SchoolGuy I know this is getting a little confusing, please let me know how you would like to proceed. This version I believe is finally acceptable, but I can resubmit under a new PR, or try to separate some things into individual blog posts, like the "cobbler import" method vs. the "cobbler repo add" method. I also have other guides I would like to get posted like Ubuntu, Windows, FreeBSD, and XCP-ng that I believe may help with some development efforts, so let me know if I should shift to working on those. Or I can get some more simple guides up, like Oracle Linux or OpenSUSE. Thanks!!

Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with me. I find this blog post very extensive and interesting! Sorry that it took me so long to finally greenlight it.

@SchoolGuy SchoolGuy merged commit 1c3ca0a into cobbler:main Jan 27, 2025
1 check passed
@sus-admin
Copy link
Contributor Author

@SchoolGuy Thanks for the positive feedback! I'm very excited to have your approval on these, and I'm actually glad we waited to merge this, those last few edits I made were pretty important. I think I will try to submit an Ubuntu guide next, maybe it can help with this PR in some way: Cloud-Init Support.
I'm also hoping to get a Windows deployment guide up since that is working so well in 3.3.7 (thanks for your attention on this: cobbler/cobbler#3819 ). Really appreciate all you do to keep this project moving forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants