kvclient: remove ReturnOnRangeBoundary request option #151915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@dt We noticed this when reading through some code. If you think it's likely we'll use this it isn't too bad to keep around. |
This was added in cockroachdb#70763 with the intention of using it for the ExportRequests sent by backup processors. In cockroachdb#114268 we went with a different approach and this feature has not seen subsequent use. BatchRequest options that may result in partial batch results require special thinking/handling at multiple points in dist_sender, so it seems sensible to remove this option if it is unused. Epic: none Release note: None
stevendanna
force-pushed
the
ssd/remove-return-on-range-boundary
branch
from
6eab846 to
eca8dc6
Compare
dt
approved these changes
Aug 15, 2025
miraradeva
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)
|
TFTR! bors r=dt,miraradeva |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #70763 with the intention of using it for the ExportRequests sent by backup processors.
In #114268 we went with a different approach and this feature has not seen subsequent use.
BatchRequest options that may result in partial batch results require special thinking/handling at multiple points in dist_sender, so it seems sensible to remove this option if it is unused.
Epic: none
Release note: None