sql/schemachanger: fix incorrect clean up of sequnece ownership #151947
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
added
backport-24.1.x
Previously, when a default expression was cleaned up the sequence ownerships would be incorrectly cleaned up. This meant when we added support for setting default expressions in the declarative schema changer, any updates could wipe out sequence ownership information. To address this, this patch removes the incorrect clean up logic. Fixes: cockroachdb#151925 Release note (bug fix): Updating column default expressions would incorrectly remove sequence ownerships for the affected column.
fqazi
force-pushed
the
fixBadDefaultExpressionCleanup
branch
from
5e94eea to
b978807
Compare
rafiss
requested changes
Aug 19, 2025
| drop table t_seq_owner; | ||
|
|
||
| query I | ||
| SELECT count(*) FROM [SHOW TABLES] WHERE table_name='id_seq_owned' |
There was a problem hiding this comment.
can we look at the pg_sequences table instead? and let's also make sure t_seq_owner_id_seq got cleaned up.
| @@ -280,7 +280,6 @@ func updateColumnExprSequenceUsage(d *descpb.ColumnDescriptor) error { | |||
| ids.ForEach(all.Add) | |||
| } | |||
| d.UsesSequenceIds = all.Ordered() | |||
| d.OwnsSequenceIds = all.Ordered() | |||
There was a problem hiding this comment.
one thing i'm wondering is if we need to special case IDENTITY columns. aren't those implemented with a default expression, and the column should own the backing sequence? or is that handled separately? (since tests passed i assume it's fine, but i'm just curious.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a default expression was cleaned up the sequence ownerships would be incorrectly cleaned up. This meant when we added support for setting default expressions in the declarative schema changer, any updates could wipe out sequence ownership information. To address this, this patch removes the incorrect clean up logic.
Fixes: #151925
Release note (bug fix): Updating column default expressions would incorrectly remove sequence ownerships for the affected column.