[tiering prototype] go.mod: bump Pebble, update SpanPolicyFunc

[RaduBerinde]

Changes:

• df18f0ea options: change SpanPolicyFunc to take UserKeyBounds
• 97dec880 db: add tiering policy

Release note: none.
Epic: none.

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[sumeerbhola]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)

---

pkg/storage/pebble.go line 627 at r1 (raw file):

			policy.PreferFastCompression = true
		}
		if len(policy.KeyRange.End) == 0 {

How about a comment like
// For a key >= spanPolicyLockTableEndKey, which is the last configured policy, spanPolicyFunc, returns a policy [spanPolicyLockTableEndKey, ""), so we need to fix this to not extend until infinity.

---

pkg/storage/pebble.go line 632 at r1 (raw file):

		return policy, nil
	}
	return pebble.SpanPolicy{}, nil

Every policy needs a populated KeyRange, so I think this needs to be KeyRange{spanPolicyLocalEndKey, ""}.

[RaduBerinde]

TFTR!

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)

---

pkg/storage/pebble.go line 627 at r1 (raw file):

Previously, sumeerbhola wrote…

How about a comment like
// For a key >= spanPolicyLockTableEndKey, which is the last configured policy, spanPolicyFunc, returns a policy [spanPolicyLockTableEndKey, ""), so we need to fix this to not extend until infinity.

Done.

---

pkg/storage/pebble.go line 632 at r1 (raw file):

Previously, sumeerbhola wrote…

Every policy needs a populated KeyRange, so I think this needs to be KeyRange{spanPolicyLocalEndKey, ""}.

Done.

[sumeerbhola]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)