mma: fix minor todos related to pending changes #157933
Merged
+29
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
sumeerbhola
commented
Nov 17, 2025
Collaborator
Author
sumeerbhola
left a comment
sumeerbhola
left a comment
There was a problem hiding this comment.
Only look at the second commit. The first commit is from #157930
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @tbg and @wenyihu6)
wenyihu6
approved these changes
Nov 17, 2025
Contributor
wenyihu6
left a comment
wenyihu6
left a comment
There was a problem hiding this comment.
Reviewable status:
Some methods now take a PendingRangeChange as parameter, insted of a slice of pendingReplicaChanges, to make it clearer that these are changes for the same range. Also removed two todos: - The RangeID continues to be a field in pendingReplicaChange, since it is convenient (mainly for logging and testing), despite redundancy with the containing PendingRangeChange. This is because the contained relationship is not maintained in various maps keyed by the changeID. - The changes in a rangeState are not modeled as a PendingRangeChange since the concept is redundant -- they are already contained in a range specific container. Informs cockroachdb#157049 Epic: CRDB-55052 Release note: None
sumeerbhola
force-pushed
the
pending_changes4
branch
from
34b0d35 to
6a5f0d6
Compare
Collaborator
Author
|
TFTR! Rebased on master. |
Collaborator
Author
|
bors r=wenyihu6 |
craig bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
157908: kvpb: add (*RangeFeedEvent).EventType method r=wenyihu6 a=stevendanna A small helper for printing the type of an event since this type is enum-like. Informs #135332 Release note: None 157933: mma: fix minor todos related to pending changes r=wenyihu6 a=sumeerbhola Some methods now take a PendingRangeChange as parameter, insted of a slice of pendingReplicaChanges, to make it clearer that these are changes for the same range. Also removed two todos: - The RangeID continues to be a field in pendingReplicaChange, since it is convenient (mainly for logging and testing), despite redundancy with the containing PendingRangeChange. This is because the contained relationship is not maintained in various maps keyed by the changeID. - The changes in a rangeState are not modeled as a PendingRangeChange since the concept is redundant -- they are already contained in a range specific container. Informs #157049 Epic: CRDB-55052 Release note: None 157953: release: released CockroachDB version v26.1.0-alpha.0. Next version: v26.1.0-alpha.1 r=celiala a=cockroach-teamcity Release note: None Epic: None Release justification: non-production (release infra) change. 157956: roachtest/vecindex: Always download datasets when testing r=mw5h a=mw5h Previously, the vecindex roachtest would use the vecann default of attempting to reuse cached dataset files. This led to a situation where a test runner apparently cached a truncated file, causing the test to fail repeatedly when run from that runner. This patch changes the behavior to always download the dataset, so the test doesn't repeatedly flake. Fixes: #157119 Release note: None Co-authored-by: Steven Danna <[email protected]> Co-authored-by: sumeerbhola <[email protected]> Co-authored-by: Justin Beaver <[email protected]> Co-authored-by: Matt White <[email protected]>
Contributor
|
Build failed (retrying...): |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some methods now take a PendingRangeChange as parameter, insted of a slice
of pendingReplicaChanges, to make it clearer that these are changes for
the same range.
Also removed two todos:
convenient (mainly for logging and testing), despite redundancy with the
containing PendingRangeChange. This is because the contained relationship
is not maintained in various maps keyed by the changeID.
the concept is redundant -- they are already contained in a range specific
container.
Informs #157049
Epic: CRDB-55052
Release note: None