jobs: fix TestJitterCalculation failed #157951
Open
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test will sometimes fail due to a randomly picking a value that rounds to 1/2. Using a deterministic seed ensures the test will never flake. Release note: none Fixes: cockroachdb#128381 Fixes: cockroachdb#157113
jeffswenson
added
the
backport-all
Member
|
This change is |
stevendanna
reviewed
Nov 17, 2025
| // where the test flakes because the random value rounds to 1/2. This is more | ||
| // common than you would expect because its probability is based on the width | ||
| // of the duration, not the width of the random float. | ||
| rand.Seed(4) |
Collaborator
There was a problem hiding this comment.
I was a little concerned that setting this global seed might impact other randomized tests. But then I read that perhaps this isn't doing what we want in the first place:
// As of Go 1.24 [Seed] is a no-op. To restore the previous behavior set
// GODEBUG=randseednop=0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test will sometimes fail due to a randomly picking a value that rounds to 1/2. Using a deterministic seed ensures the test will never flake.
Release note: none
Fixes: #128381
Fixes: #157113