Skip to content

release-24.3: sql: deflake TestIndexBackfillAfterGC#164313

Merged
fqazi merged 1 commit intocockroachdb:release-24.3from
fqazi:blathers/backport-release-24.3-164297
Feb 25, 2026
Merged

release-24.3: sql: deflake TestIndexBackfillAfterGC#164313
fqazi merged 1 commit intocockroachdb:release-24.3from
fqazi:blathers/backport-release-24.3-164297

Conversation

@fqazi
Copy link
Collaborator

@fqazi fqazi commented Feb 24, 2026

Backport 1/1 commits from #164297 on behalf of @fqazi.


Skip TestIndexBackfillAfterGC under race, since it can be timing sensitive.

Fixes: #161759

Release note: None


Release justification: test only change

Skip TestIndexBackfillAfterGC under race, since it can be timing
sensitive.

Fixes: cockroachdb#161759

Release note: None
@fqazi fqazi requested a review from a team as a code owner February 24, 2026 23:26
@fqazi fqazi force-pushed the blathers/backport-release-24.3-164297 branch from df371b2 to 69aa711 Compare February 24, 2026 23:26
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 24, 2026
@blathers-crl blathers-crl bot requested a review from rafiss February 24, 2026 23:26
@blathers-crl
Copy link

blathers-crl bot commented Feb 24, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Feb 24, 2026
@blathers-crl
Copy link

blathers-crl bot commented Feb 24, 2026

✅ PR #164313 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The pull request is a test-only change which is exempt from the standard backport policy requirements. The modified file, pkg/sql/schema_changer_test.go, clearly indicates that the change is within a test function TestIndexBackfillAfterGC. The added line uses a function to skip the test under certain conditions, labeled as 'flaky under race'. This falls within the policy exception for non-production changes. Moreover, the PR body explicitly mentions 'Release justification: test only change', further supporting the exemption based on test-only modifications.

ENGREQ Check Skipped: Test-only backport.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Feb 25, 2026
@fqazi fqazi merged commit e61c3f3 into cockroachdb:release-24.3 Feb 25, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) target-release-24.3.29

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants