Skip to content

release-25.4: sql: deflake TestIndexBackfillAfterGC#164315

Merged
fqazi merged 1 commit intocockroachdb:release-25.4from
fqazi:blathers/backport-release-25.4-164297
Feb 25, 2026
Merged

release-25.4: sql: deflake TestIndexBackfillAfterGC#164315
fqazi merged 1 commit intocockroachdb:release-25.4from
fqazi:blathers/backport-release-25.4-164297

Conversation

@fqazi
Copy link
Collaborator

@fqazi fqazi commented Feb 24, 2026

Backport 1/1 commits from #164297 on behalf of @fqazi.


Skip TestIndexBackfillAfterGC under race, since it can be timing sensitive.

Fixes: #161759

Release note: None


Release justification: test only change

Skip TestIndexBackfillAfterGC under race, since it can be timing
sensitive.

Fixes: cockroachdb#161759

Release note: None
@fqazi fqazi requested a review from a team as a code owner February 24, 2026 23:26
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 24, 2026
@blathers-crl blathers-crl bot requested a review from rafiss February 24, 2026 23:26
@blathers-crl
Copy link

blathers-crl bot commented Feb 24, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Feb 24, 2026
@blathers-crl
Copy link

blathers-crl bot commented Feb 24, 2026

✅ PR #164315 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: This PR qualifies as compliant based on the backport policy for CockroachDB. The PR changes only a test file (pkg/sql/schema_changer_test.go), as indicated by the '_test.go' suffix, which means it falls under the category of non-production code changes. Therefore, the changes are exempt from the standard backport policy requirements that typically necessitate fixing a critical bug or being gated behind a feature flag. Moreover, the PR body explicitly includes a 'Release justification: test only change,' further supporting its exemption from the standard requirements given it only affects the test code. These factors confirm that the PR is indeed compliant with the backport policy, as it neither alters production code nor requires additional gating.

ENGREQ Check Skipped: Test-only backport.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Feb 24, 2026
@fqazi fqazi merged commit 191aab8 into cockroachdb:release-25.4 Feb 25, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) target-release-25.4.7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants