workload/kv: refactor to add dialects#164319
Draft
golgeek wants to merge 1 commit intocockroachdb:masterfrom
Draft
workload/kv: refactor to add dialects#164319golgeek wants to merge 1 commit intocockroachdb:masterfrom
golgeek wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Until now, workload was only compatible with CRDB. This patch introduces the concept of dialect to make the KV workload compatible with other dialects (PostgreSQL, Spanner and CRDB at first). The patch implements `--dialect` for both `workload init kv` and `workload run kv` commands. This feature is limited to the KV workload for now. Epic: CRDB-60563 Fixes: cockroachdb#164224
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Contributor
|
Merging to
|
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, workload was only compatible with CRDB.
This patch introduces the concept of dialect to make the KV workload compatible with other dialects (PostgreSQL, Spanner and CRDB at first). The patch implements
--dialectfor bothworkload init kvandworkload run kvcommands.This feature is limited to the KV workload for now.
Epic: CRDB-60563
Fixes: #164224