*: migrate to factory options for test server defaults#164324
Open
Nukitt wants to merge 1 commit intocockroachdb:masterfrom
Open
*: migrate to factory options for test server defaults#164324Nukitt wants to merge 1 commit intocockroachdb:masterfrom
Nukitt wants to merge 1 commit intocockroachdb:masterfrom
Conversation
This change removes the deprecated `TestingGlobalDRPCOption` and `TestingSetDefaultTenantSelectionOverride` global override functions and migrates all usages to the new factory option pattern using `WithDRPCOption` and `WithTenantOption` passed to `InitTestServerFactory`. This provides several benefits: - Options are applied at factory initialization time, not via global state - No need for defer/cleanup patterns We now also have a clearer and uniform priority order for overides: `test explicit > env vars > factory defaults > metamorphic` Epic: CRDB-55382 Fixes: cockroachdb#164250 Fixes: cockroachdb#164251 Release note: None
Contributor
|
Merging to
|
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Nukitt
requested review from
ZhouXing19,
alyshanjahani-crl,
dt and
jeffswenson
and removed request for
a team
stevendanna
approved these changes
Feb 25, 2026
Collaborator
stevendanna
left a comment
stevendanna
left a comment
There was a problem hiding this comment.
Thanks for doing this cleanup!
I didn't review every mechanical code change here. I did try to review the test_server_shim.go changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the deprecated
TestingGlobalDRPCOptionandTestingSetDefaultTenantSelectionOverrideglobal override functions and migrates all usages to the new factory option pattern usingWithDRPCOptionandWithTenantOptionpassed toInitTestServerFactory.This provides several benefits:
We now also have a clearer and uniform priority order for overides:
test explicit > env vars > factory defaults > metamorphicEpic: CRDB-55382
Fixes: #164250
Fixes: #164251
Release note: None