Skip to content

release-25.4.6-rc: kvserver: create a fresh context per-store-rebalancer loop iteration#164361

Merged
arulajmani merged 1 commit intocockroachdb:release-25.4.6-rcfrom
arulajmani:backportrelease-25.4.6-rc-164202
Feb 26, 2026
Merged

release-25.4.6-rc: kvserver: create a fresh context per-store-rebalancer loop iteration#164361
arulajmani merged 1 commit intocockroachdb:release-25.4.6-rcfrom
arulajmani:backportrelease-25.4.6-rc-164202

Conversation

@arulajmani
Copy link
Collaborator

Backport 1/1 commits from #164202 on behalf of @arulajmani.


kvserver: create a fresh context per-store-rebalancer loop iteration

We've seen this cause issues in older versions of CRDB, where we don't have fastValueCtxs. There, the depth of the context chain increases once per-iteration, which is unnecessary.


Release justification: bug fix for context chain depth growth in store rebalancer

We've seen this cause issues in older versions of CRDB, where we don't
have fastValueCtxs. There, the depth of the context chain increases once
per-iteration, which is unecessary.

Epic: none

Release note: None
@arulajmani arulajmani requested a review from a team as a code owner February 25, 2026 15:03
@blathers-crl
Copy link

blathers-crl bot commented Feb 25, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-kv KV Team labels Feb 25, 2026
@blathers-crl
Copy link

blathers-crl bot commented Feb 25, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Feb 25, 2026

❌ PR #164361 does not comply with backport policy

Confidence: high
Explanation: This PR is proposed as a backport based on the resolution of increased context chain depth in older versions of the store rebalancer. This change does not clearly match the predefined critical bug criteria as it does not affect stability or security, lead to data loss/corruption, cause significant performance regressions, result in incorrect query results, nor make debugging more difficult in a way that is critical. It appears to be a performance and quality of life improvement but lacks direct and immediate production impact as defined by critical bug criteria.
Recommendation: Reconsider the backport as it does not meet the critical bug fix criteria or ensure it is introduced behind a feature flag to maintain compliance with backport policies.

ENGREQ Check Failed: Please check one of the backport category checkboxes.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@arulajmani arulajmani merged commit ceb4865 into cockroachdb:release-25.4.6-rc Feb 26, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-kv KV Team target-release-25.4.6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants