Skip to content

sql: support statement hint in routine body with SQL language#164365

Open
ZhouXing19 wants to merge 1 commit intocockroachdb:masterfrom
ZhouXing19:routine-hints
Open

sql: support statement hint in routine body with SQL language#164365
ZhouXing19 wants to merge 1 commit intocockroachdb:masterfrom
ZhouXing19:routine-hints

Conversation

@ZhouXing19
Copy link
Collaborator

@ZhouXing19 ZhouXing19 commented Feb 25, 2026

informs: #162627

This commit is to ensure statements within routines defined by SQL
language respect hint injections.

Note that the routines written in PLpgSQL language are not covered in
this commit.

Release note (bug fix): ensure statements within routines body defined by SQL
language respect hint injections.

@trunk-io
Copy link
Contributor

trunk-io bot commented Feb 25, 2026

Merging to master in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@blathers-crl
Copy link

blathers-crl bot commented Feb 25, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

ZhouXing19 added a commit to ZhouXing19/cockroach that referenced this pull request Feb 26, 2026
informs: cockroachdb#164365

This commit is to ensure statements within routines defined by SQL
languagedo respect hint injections.

Release note: TBD
ZhouXing19 added a commit to ZhouXing19/cockroach that referenced this pull request Feb 27, 2026
informs: cockroachdb#164365

This commit is to ensure statements within routines defined by SQL
languagedo respect hint injections.

Release note: TBD
ZhouXing19 added a commit to ZhouXing19/cockroach that referenced this pull request Feb 27, 2026
informs: cockroachdb#164365

This commit is to ensure statements within routines defined by SQL
languagedo respect hint injections.

Note that the routines written in PLpgSQL language are not covered in
this commit.

Release note (bug fix): ensure statements within routines body defined by SQL
languagedo respect hint injections.
@ZhouXing19 ZhouXing19 changed the title [WIP] sql: support statement hint in routines sql: support statement hint in routine body with SQL language Feb 27, 2026
@ZhouXing19 ZhouXing19 marked this pull request as ready for review February 27, 2026 02:54
@ZhouXing19 ZhouXing19 requested a review from a team as a code owner February 27, 2026 02:54
informs: cockroachdb#164365

This commit is to ensure statements within routines defined by SQL
language respect hint injections.

Note that the routines written in PLpgSQL language are not covered in
this commit.

Release note (bug fix): ensure statements within routines body defined
by SQL language respect hint injections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants