Skip to content

sql: reject qualified column names that match whole-row references #174772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alignyx wants to merge 1 commit into
base: master
Choose a base branch
from
+50 −4
Open

sql: reject qualified column names that match whole-row references #174772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions pkg/sql/opt/optbuilder/scope.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,10 +1079,14 @@ func (s *scope) VisitPre(expr tree.Expr) (recurse bool, newExpr tree.Expr) {
}
// Attempt to resolve as columnname.*, which allows items
// such as SELECT row_to_json(tbl_name) FROM tbl_name to work.
return func() (bool, tree.Expr) {
defer wrapColTupleStarPanic(resolveErr)
return s.VisitPre(columnNameAsTupleStar(string(t.ColumnName)))
}()
// Qualified column references such as t1.t1 must not fall back to
// whole-row tuple expansion; retain the resolver error instead.
if t.TableName == nil || t.TableName.Object() == "" {
return func() (bool, tree.Expr) {
defer wrapColTupleStarPanic(resolveErr)
return s.VisitPre(columnNameAsTupleStar(string(t.ColumnName)))
}()
}
}
if sqlerrors.IsUndefinedRelationError(resolveErr) && t.TableName.Object() != "" {
// If we are inside a PL/pgSQL routine and the prefix names a
Expand Down
42 changes: 42 additions & 0 deletions pkg/sql/opt/optbuilder/testdata/qualified-whole-row
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
exec-ddl
CREATE TABLE t1(f1 INT)
----

exec-ddl
CREATE TABLE t2(f1 INT)
----

build
SELECT t1.t1 FROM t1
----
error (42703): column "t1.t1" does not exist

build
SELECT a.a FROM t1 AS a
----
error (42703): column "a.a" does not exist

build
SELECT * FROM t1 WHERE t1.t2 = 1
----
error (42703): column "t1.t2" does not exist

build
SELECT t1.t2 FROM t1, t2
----
error (42703): column "t1.t2" does not exist

build
WITH c AS (SELECT 1 AS x) SELECT c.y FROM c
----
error (42703): column "c.y" does not exist

build
SELECT d.y FROM (SELECT 1 AS x) AS d
----
error (42703): column "d.y" does not exist

build
SELECT (SELECT o.t2 FROM t1) FROM t1 AS o
----
error (42703): column "o.t2" does not exist